Microsoft/bcquality
1
0
Fork 0
mirror of https://github.com/microsoft/BCQuality.git synced 2026-10-05 14:46:55 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 4
bcquality/microsoft/knowledge/performance/use-get-instead-of-findfirst-on-full-primary-key.md
Jesper Schulz-Wedde 2b5550c346
Some checks failed
Validate knowledge index / validate-index (push) Has been cancelled
Details
Validate AL review fixtures / validate-review-fixtures (push) Has been cancelled
Details
Validate frontmatter and structure / validate (push) Has been cancelled
Details
Improve partner onboarding and documentation navigation (#174) 
Lead with a complete plugin quick start and add task-oriented usage, troubleshooting, customization, and contribution guides. Preserve the broader plugin framing, correct conflicting contract guidance, support Agents folder reviews, and align repository validation. Convert existing sample references to clickable links without changing knowledge rules.

Co-authored-by: Jesper Schulz-Wedde <jesper.schulzwedde@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-09-09 17:31:03 +02:00

1.5 KiB
Raw Blame History

bc-version domain keywords technologies countries application-area
all
performance
get
findfirst
primary-key
setrange
lookup
al
w1
all

Use Get when the full primary key is known; FindFirst is the wrong tool

Description

Get(...) is the direct primary-key lookup. FindFirst() walks an index — even when narrowed by SetRange on every primary-key field. The upstream review guidance treats Customer.SetRange("No.", CustomerNo); if Customer.FindFirst() then ... as a bad pattern and if Customer.Get(CustomerNo) then ... as the correction. The two reach the same record; only Get expresses the lookup as a primary-key seek.

Best Practice

When all primary-key fields are available at the call site, call Get (or GetBySystemId) with them. Reserve FindFirst for cases where the filter is on something other than the full primary key — a unique secondary field, a partial composite key, a sort that the caller cares about.

See sample: use-get-instead-of-findfirst-on-full-primary-key.good.al.

Anti Pattern

Composing SetRange calls that exactly cover the primary key and then calling FindFirst. The result is correct but the call site reads as "search the table" rather than "look up by key", which obscures both the intent and the access pattern from later reviewers.

See sample: use-get-instead-of-findfirst-on-full-primary-key.bad.al.