bcquality/microsoft/knowledge/performance/isempty-before-findset-is-extra-round-trip.md
Jesper Schulz-Wedde 2b5550c346
Some checks failed
Validate knowledge index / validate-index (push) Has been cancelled
Validate AL review fixtures / validate-review-fixtures (push) Has been cancelled
Validate frontmatter and structure / validate (push) Has been cancelled
Improve partner onboarding and documentation navigation (#174)
Lead with a complete plugin quick start and add task-oriented usage, troubleshooting, customization, and contribution guides. Preserve the broader plugin framing, correct conflicting contract guidance, support Agents folder reviews, and align repository validation. Convert existing sample references to clickable links without changing knowledge rules.

Co-authored-by: Jesper Schulz-Wedde <jesper.schulzwedde@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-09-09 17:31:03 +02:00

1.4 KiB

bc-version domain keywords technologies countries application-area
all
performance
isempty
findset
extra-round-trip
existence-check
false-positive
al
w1
all

IsEmpty immediately before FindSet is an extra round-trip

Contributions welcome — open a PR to refine or extend this article.

Description

IsEmpty is the right API when the caller only needs existence — see microsoft/knowledge/performance/use-isempty-for-existence-check.md. It is not a cheap guard in front of a loop that will FindSet anyway. Both calls hit the database; FindSet already returns false when the filter matches nothing. Agents and reviewers often insert if not Rec.IsEmpty() then "for performance" and pay a second query for a result the iterator already provides.

Best Practice

When the body iterates, open with if Rec.FindSet() then repeat ... until Next() = 0. Do not flag a bare FindSet loop as missing an IsEmpty precondition. Reserve IsEmpty for branches that never materialize the row set.

See sample: isempty-before-findset-is-extra-round-trip.good.al.

Anti Pattern

if not Rec.IsEmpty() then if Rec.FindSet() then repeat. Also a false-positive review comment that asks to add that guard. The second read does not avoid the first; it duplicates it.

See sample: isempty-before-findset-is-extra-round-trip.bad.al.