mirror of https://github.com/microsoft/BCQuality.git synced 2026-10-05 22:56:55 +01:00

Michael Dieringer dd5637b1db Custom-laget bestaar nu begge CI-checks: 72 validator-fejl -> 0

Normalisering af alle 39 custom knowledge-filer til READ-kontraktens
skema (validate_frontmatter.py + Test-KnowledgeIndex.ps1 begge groenne):

- R01/R02: 28 filer manglede frontmatter eller brugte aeldre skemaer
  (title/category/severity/rule-id m.fl.) - alle har nu praecis de 6
  kraevede noegler; keywords haandskrevet pr. fil da de driver
  worklist-selektionen i INDEX/knowledge-index
- R09: manglende Description-sektion - regel-agtige foersteoverskrifter
  (Core Rule/Rule/Regel/Core Principle) omdoebt, eller sektion indsat
  efter titlen hvor intro-tekst fandtes
- R10: fenced code blocks konverteret til 4-space indrykkede blokke
  i alle filer (indhold uaendret)
- R11: 4 filer over 100 linjer fortaettet redaktionelt uden semantisk
  tab (ai-eval-scores 143->100, git-lifecycle 121->97,
  permission-sets 113->99, test-feature-scenario-tags 105->91)
- R05: AL0197->al0197, add_repo->add-repo; keyword-lister trimmet
  til maks 10

Ingen regler er fjernet eller aendret i betydning - kun form.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

2026-07-01 23:47:31 +02:00

1.5 KiB

Raw Blame History

bc-version

domain

keywords

technologies

countries

application-area

all

mcp

s2s

developer-identity

users-api

all

Agent must resolve developer identity from BC

Description

Agent files must not contain static employee-to-code mappings. Developer identity must always be resolved at runtime from the BC users tool (PAG6102903).

Rationale

Employee data is owned by the company, not by any individual project. A static mapping in a project-level agent file duplicates company data and will silently drift on every personnel change -- a new hire is missing, a former employee remains listed.

The BC users page (PAG6102903) is the single source of truth for employeeCode + name

userId mapping. Resolving identity at runtime ensures attribution is always correct without any maintenance overhead on the project side.

What this prevents

Incorrect task attribution after an employee leaves or changes role
N agent files requiring manual update for a single personnel change
Silent drift where an agent signs comments with the wrong name

Correct pattern

In bc-mcp agent: always resolve at runtime. git config user.email -> look up via users tool (PAG6102903) -> employeeCode + name

Incorrect pattern

Static employee tables in agent files are forbidden:

Exceptions

None. If the users tool is temporarily unavailable, say so and stop -- do not fall back to a hardcoded table.

1.5 KiB Raw Blame History