bcquality/microsoft/knowledge/upgrade/use-obsolete-pending-before-removed.md
Jesper Schulz-Wedde e570d6113f Extract 55 knowledge articles from BC review-agent prompt
Adds 55 articles (plus 76 code samples) spanning four new domains and
two existing domains, extracted from the internal Business Central
review-agent prompt. Content was filtered against BCQuality's
remedial-knowledge premise: each article encodes BC-specific behaviour,
a CodeCop rule, a platform API semantic, or an anti-false-positive
guideline that a capable LLM would otherwise get wrong.

New domains:
- privacy (11 articles): DataClassification inheritance semantics, the
  StrSubstNo-defeats-Error-telemetry-classification pitfall, Privacy
  Notice consent for outgoing requests, anti-false-positives for pages
  and in-memory data.
- upgrade (11 articles): upgrade-codeunit structure, upgrade-tag
  lifecycle and registration, protected DB reads, DataTransfer for
  large datasets, InitValue semantics, enum-ordinal preservation,
  obsolete-workflow, first-install detection.
- ui (9 articles): caption capitalization by phrase type, tooltip voice,
  teaching-tip vs tooltip, tour-tip conventions, character limits,
  banned terms, ampersand handling, title punctuation.
- style (11 articles): label-suffix convention, API page naming,
  temporary-variable prefix, label properties (Comment/Locked), named
  invocations, FieldCaption in user messages, OptionCaption pairing,
  Error-parameter passing, `this` keyword, required parentheses, file
  naming.

Gaps in existing domains:
- performance (11 articles): production-scale table catalog (no row
  counts, per internal-data concern), anti-false-positive for bounded
  tables, guard-before-Get ordering, redundant-Get-in-OnAfterGetRecord,
  LockTable in read-only helpers, combined ModifyAll passes, writes in
  OnAfterGetRecord, SetLoadFields heuristics, temporary-table
  regressions, FlowField source-table widening, MaintainSQLIndex
  disabling SIFT.
- security (2 articles): environment-specific hardcoded GUIDs,
  ValidateTableRelation=false on user input.

Intentionally excluded: specific production P95 row-count numbers
(aggregated internal telemetry); rewritten as categorical guidance on
which tables to treat as production-scale without publishing sizes.

All articles use `bc-version: [all]` (applies to every BC version, per
the new schema sentinel). Validator passes with 0 errors / 0 warnings.
2026-04-23 16:43:42 +02:00

1.5 KiB

bc-version domain keywords technologies countries application-area
all
upgrade
obsolete
obsoletestate
obsoletereason
obsoletetag
deprecation
al
w1
all

Deprecate via ObsoleteState Pending first; move to Removed only after the grace window

Description

AL's obsolete workflow is two-stage by design. ObsoleteState = Pending keeps the object or member compilable and callable but emits warnings and records the deprecation in metadata. ObsoleteState = Removed makes it a compile error for callers. Jumping straight to Removed — or marking Pending without ObsoleteReason and ObsoleteTag — breaks dependents who had no signal to migrate, and loses the tooling's ability to surface the planned removal in sandbox builds before the production tenant upgrades.

Best Practice

Mark the element ObsoleteState = Pending with a concrete ObsoleteReason naming the replacement and an ObsoleteTag identifying the version the deprecation started. Keep it Pending through at least one major release so dependents have a cycle to migrate. Move to ObsoleteState = Removed only in a later release, with the same Reason and Tag retained or updated.

See sample: use-obsolete-pending-before-removed.good.al.

Anti Pattern

[Obsolete('', '')] or ObsoleteState = Removed applied directly on an element that was public and callable in the previous release, with no preceding Pending phase. Dependents get a hard compile error with no migration signal in the previous version.

See sample: use-obsolete-pending-before-removed.bad.al.