mirror of
https://github.com/microsoft/BCQuality.git
synced 2026-08-06 17:36:53 +01:00
61 lines
4.2 KiB
Markdown
61 lines
4.2 KiB
Markdown
---
|
|
kind: action-skill
|
|
id: curabis-al-code-review
|
|
version: 1
|
|
title: CURABIS AL code review
|
|
description: Reviews AL source changes against BCQuality knowledge and CURABIS-specific architecture rules.
|
|
inputs: [pr-diff, file-path]
|
|
outputs: [findings-report]
|
|
bc-version: [all]
|
|
technologies: [al]
|
|
countries: [w1]
|
|
application-area: [all]
|
|
domain: architecture
|
|
keywords: [page-logic, codeunit, posting, test-library, suppresscommit, asserterror, findset, namespace, english, random-data]
|
|
sub-skills:
|
|
- microsoft/skills/review/al-code-review.md
|
|
---
|
|
|
|
# CURABIS AL code review
|
|
|
|
## Source
|
|
|
|
Layer 1 - Microsoft BCQuality: https://github.com/microsoft/BCQuality
|
|
|
|
Layer 2 - CURABIS custom knowledge (fetch before applying rules):
|
|
- https://raw.githubusercontent.com/Curabis/BCQuality/main/custom/knowledge/architecture/pages-must-not-contain-business-logic.md
|
|
- https://raw.githubusercontent.com/Curabis/BCQuality/main/custom/knowledge/architecture/namespace-must-be-verified-from-source.md
|
|
- https://raw.githubusercontent.com/Curabis/BCQuality/main/custom/knowledge/architecture/al-identifiers-must-be-english.md
|
|
- https://raw.githubusercontent.com/Curabis/BCQuality/main/custom/knowledge/architecture/clarify-before-building.md
|
|
- https://raw.githubusercontent.com/Curabis/BCQuality/main/custom/knowledge/architecture/xliff-translation-workflow.md
|
|
- https://raw.githubusercontent.com/Curabis/BCQuality/main/custom/knowledge/architecture/new-file-requires-vscode-refresh.md
|
|
- https://raw.githubusercontent.com/Curabis/BCQuality/main/custom/knowledge/architecture/exposed-objects-must-be-in-a-permission-set.md
|
|
- https://raw.githubusercontent.com/Curabis/BCQuality/main/custom/knowledge/architecture/shared-project-memory-must-be-in-repo.md
|
|
- https://raw.githubusercontent.com/Curabis/BCQuality/main/custom/knowledge/architecture/commit-message-must-include-bc-task-id.md
|
|
- https://raw.githubusercontent.com/Curabis/BCQuality/main/custom/knowledge/architecture/branch-merge-to-main-workflow.md
|
|
- https://raw.githubusercontent.com/Curabis/BCQuality/main/custom/knowledge/testing/test-setup-must-use-library-codeunit.md
|
|
- https://raw.githubusercontent.com/Curabis/BCQuality/main/custom/knowledge/testing/test-data-must-be-random-and-complete.md
|
|
- https://raw.githubusercontent.com/Curabis/BCQuality/main/custom/knowledge/testing/tests-must-adapt-to-existing-code.md
|
|
- https://raw.githubusercontent.com/Curabis/BCQuality/main/custom/knowledge/testing/test-one-when-per-test.md
|
|
- https://raw.githubusercontent.com/Curabis/BCQuality/main/custom/knowledge/testing/ui-test-codeunit-naming.md
|
|
- https://raw.githubusercontent.com/Curabis/BCQuality/main/custom/knowledge/testing/test-feature-scenario-tags.md
|
|
- https://raw.githubusercontent.com/Curabis/BCQuality/main/custom/knowledge/mcp/api-page-flowfields-must-be-calcfields.md
|
|
- https://raw.githubusercontent.com/Curabis/BCQuality/main/custom/knowledge/mcp/stored-derived-fields-must-not-be-exposed-directly.md
|
|
- https://raw.githubusercontent.com/Curabis/BCQuality/main/custom/knowledge/mcp/api-page-key-fields-must-be-editable-on-insert.md
|
|
- https://raw.githubusercontent.com/Curabis/BCQuality/main/custom/knowledge/mcp/api-page-least-privilege-write-access.md
|
|
- https://raw.githubusercontent.com/Curabis/BCQuality/main/custom/knowledge/mcp/agent-must-not-write-business-process-status.md
|
|
- https://raw.githubusercontent.com/Curabis/BCQuality/main/custom/knowledge/mcp/bc-mcp-find-active-task-for-branch.md
|
|
|
|
## Action
|
|
|
|
CURABIS-ARCH-001: Logic belongs in codeunits, not pages.
|
|
CURABIS-ARCH-002: Pages must not call Modify/Insert/Delete directly.
|
|
CURABIS-ARCH-003: Test setup must use the project Test Library.
|
|
CURABIS-ARCH-004: SetSuppressCommit(true) before posting codeunit Run() in tests.
|
|
CURABIS-ARCH-005: asserterror must be followed by an assertion.
|
|
CURABIS-ARCH-006: FindSet(true) only before Modify() inside a loop.
|
|
CURABIS-ARCH-007: Test data must be random - never hardcode codes or names.
|
|
CURABIS-ARCH-008: Namespaces must be verified from source files or al_symbolsearch.
|
|
CURABIS-ARCH-009: All AL identifiers must be English (ENU).
|
|
CURABIS-ARCH-010: Clarify before building if task is ambiguous.
|
|
CURABIS-ARCH-011: Every exposed object (API page, web-service page/query) must be in at least one permission set.
|