mirror of
https://github.com/microsoft/BCQuality.git
synced 2026-10-05 06:36:55 +01:00
31206f6616
Addresses microsoft/BCQuality#175 review feedback: - Extend al-data-modeling-review's entry gate/relevance scope and token list to recognize document actions, Navigate subscribers, Report Selection registration, price-calculation/price-source extensibility, TransferFields posting-cascade mirroring, and barcode font-provider usage - previously excluded before any worklist cue could run. - Fix document-print-and-email-actions-call-report-selections-directly: permit the legitimate stateless DocumentSendingProfile.TrySendToPrinter/ TrySendToEMail path; rework the bad fixture to load a configured profile instead of demonstrating a trivial blank-record no-op. - Fix extend-report-selection-usage-for-new-document-types: scope to the applicable single counterparty (ReportSelectionHandlerCZZ partitions strictly; only genuinely two-sided usages like Compensation need both), and add the page-facing usage-enum map/validate events alongside the filter-event subscription for full Document Layouts support. - Fix a stale field-citation in custom-document-dispatch-must-not-bypass- report-selections (Custom Report Layout Code is field 7, not part of the 19-26 email-configuration range). - Add deterministic positive/clean evaluation coverage (review-fixtures.json additionalArticles + Test-ReviewFixtures.ps1 support) so all 9 new good/bad pairs are actually exercised, not just present. - Add 4 new patterns: activate-new-price-calculation-handler-via- onfindsupportedsetup, extend-price-source-type-must-sync-document- subset-enum, new-price-source-must-add-candidate-and-trigger- recalculation, report-barcodes-must-use-barcode-module-and-production- font-name. All claims verified against live microsoft/BCApps source and Microsoft Learn. Validators: frontmatter 0/0, review-fixtures 52 cases/17 domains PASSED, knowledge-index 309 articles PASSED. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
25 lines
1.2 KiB
AL
25 lines
1.2 KiB
AL
enumextension 50102 "Sample Price Calc Handler Ext" extends "Price Calculation Handler"
|
|
{
|
|
value(50102; "Sample Special Price")
|
|
{
|
|
Caption = 'Sample Special Price';
|
|
Implementation = "Price Calculation" = "Sample Price Calc - Special";
|
|
}
|
|
}
|
|
|
|
codeunit 50104 "Sample Price Calc Setup Install"
|
|
{
|
|
[EventSubscriber(ObjectType::Codeunit, Codeunit::"Price Calculation Mgt.", 'OnFindSupportedSetup', '', false, false)]
|
|
local procedure AddSampleSpecialPriceSetup(var TempPriceCalculationSetup: Record "Price Calculation Setup" temporary)
|
|
begin
|
|
TempPriceCalculationSetup.Init();
|
|
TempPriceCalculationSetup.Code := 'SAMPLE-SPECIAL';
|
|
TempPriceCalculationSetup.Method := TempPriceCalculationSetup.Method::"Lowest Price";
|
|
TempPriceCalculationSetup.Type := TempPriceCalculationSetup.Type::Sale;
|
|
TempPriceCalculationSetup."Asset Type" := TempPriceCalculationSetup."Asset Type"::" ";
|
|
TempPriceCalculationSetup.Implementation := TempPriceCalculationSetup.Implementation::"Sample Special Price";
|
|
TempPriceCalculationSetup.Enabled := true;
|
|
TempPriceCalculationSetup.Default := true;
|
|
TempPriceCalculationSetup.Insert();
|
|
end;
|
|
}
|