mirror of
https://github.com/microsoft/BCQuality.git
synced 2026-10-05 06:36:55 +01:00
31206f6616
Addresses microsoft/BCQuality#175 review feedback: - Extend al-data-modeling-review's entry gate/relevance scope and token list to recognize document actions, Navigate subscribers, Report Selection registration, price-calculation/price-source extensibility, TransferFields posting-cascade mirroring, and barcode font-provider usage - previously excluded before any worklist cue could run. - Fix document-print-and-email-actions-call-report-selections-directly: permit the legitimate stateless DocumentSendingProfile.TrySendToPrinter/ TrySendToEMail path; rework the bad fixture to load a configured profile instead of demonstrating a trivial blank-record no-op. - Fix extend-report-selection-usage-for-new-document-types: scope to the applicable single counterparty (ReportSelectionHandlerCZZ partitions strictly; only genuinely two-sided usages like Compensation need both), and add the page-facing usage-enum map/validate events alongside the filter-event subscription for full Document Layouts support. - Fix a stale field-citation in custom-document-dispatch-must-not-bypass- report-selections (Custom Report Layout Code is field 7, not part of the 19-26 email-configuration range). - Add deterministic positive/clean evaluation coverage (review-fixtures.json additionalArticles + Test-ReviewFixtures.ps1 support) so all 9 new good/bad pairs are actually exercised, not just present. - Add 4 new patterns: activate-new-price-calculation-handler-via- onfindsupportedsetup, extend-price-source-type-must-sync-document- subset-enum, new-price-source-must-add-candidate-and-trigger- recalculation, report-barcodes-must-use-barcode-module-and-production- font-name. All claims verified against live microsoft/BCApps source and Microsoft Learn. Validators: frontmatter 0/0, review-fixtures 52 cases/17 domains PASSED, knowledge-index 309 articles PASSED. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| activate-new-price-calculation-handler-via-onfindsupportedsetup.bad.al | ||
| activate-new-price-calculation-handler-via-onfindsupportedsetup.good.al | ||
| activate-new-price-calculation-handler-via-onfindsupportedsetup.md | ||
| check-blocked-in-referencing-code-not-in-master.bad.al | ||
| check-blocked-in-referencing-code-not-in-master.good.al | ||
| check-blocked-in-referencing-code-not-in-master.md | ||
| custom-document-dispatch-must-not-bypass-report-selections.bad.al | ||
| custom-document-dispatch-must-not-bypass-report-selections.good.al | ||
| custom-document-dispatch-must-not-bypass-report-selections.md | ||
| document-print-and-email-actions-call-report-selections-directly.bad.al | ||
| document-print-and-email-actions-call-report-selections-directly.good.al | ||
| document-print-and-email-actions-call-report-selections-directly.md | ||
| extend-find-entries-navigate-for-new-document-types.bad.al | ||
| extend-find-entries-navigate-for-new-document-types.good.al | ||
| extend-find-entries-navigate-for-new-document-types.md | ||
| extend-price-source-type-must-sync-document-subset-enum.bad.al | ||
| extend-price-source-type-must-sync-document-subset-enum.good.al | ||
| extend-price-source-type-must-sync-document-subset-enum.md | ||
| extend-report-selection-usage-for-new-document-types.bad.al | ||
| extend-report-selection-usage-for-new-document-types.good.al | ||
| extend-report-selection-usage-for-new-document-types.md | ||
| insert-only-transfer-may-rely-on-caller-cleanup.md | ||
| master-table-no-from-number-series-in-oninsert.bad.al | ||
| master-table-no-from-number-series-in-oninsert.good.al | ||
| master-table-no-from-number-series-in-oninsert.md | ||
| new-price-source-must-add-candidate-and-trigger-recalculation.bad.al | ||
| new-price-source-must-add-candidate-and-trigger-recalculation.good.al | ||
| new-price-source-must-add-candidate-and-trigger-recalculation.md | ||
| owning-table-must-delete-dependents-in-ondelete.bad.al | ||
| owning-table-must-delete-dependents-in-ondelete.good.al | ||
| owning-table-must-delete-dependents-in-ondelete.md | ||
| report-barcodes-must-use-barcode-module-and-production-font-name.bad.al | ||
| report-barcodes-must-use-barcode-module-and-production-font-name.good.al | ||
| report-barcodes-must-use-barcode-module-and-production-font-name.md | ||
| set-last-date-modified-in-onmodify-and-onrename.bad.al | ||
| set-last-date-modified-in-onmodify-and-onrename.good.al | ||
| set-last-date-modified-in-onmodify-and-onrename.md | ||
| setup-table-is-a-singleton.bad.al | ||
| setup-table-is-a-singleton.good.al | ||
| setup-table-is-a-singleton.md | ||
| share-mediaset-items-with-insert-not-field-assignment.bad.al | ||
| share-mediaset-items-with-insert-not-field-assignment.good.al | ||
| share-mediaset-items-with-insert-not-field-assignment.md | ||
| table-relation-extensions-are-additive-and-top-down.bad.al | ||
| table-relation-extensions-are-additive-and-top-down.good.al | ||
| table-relation-extensions-are-additive-and-top-down.md | ||
| transferfields-mirrored-fields-must-match-type-and-length.bad.al | ||
| transferfields-mirrored-fields-must-match-type-and-length.good.al | ||
| transferfields-mirrored-fields-must-match-type-and-length.md | ||
| transferfields-skip-type-mismatch-can-drop-data.bad.al | ||
| transferfields-skip-type-mismatch-can-drop-data.good.al | ||
| transferfields-skip-type-mismatch-can-drop-data.md | ||
| use-no-series-codeunit-not-noseriesmanagement.bad.al | ||
| use-no-series-codeunit-not-noseriesmanagement.good.al | ||
| use-no-series-codeunit-not-noseriesmanagement.md | ||
| validate-table-relation-false-suppresses-rename-propagation.bad.al | ||
| validate-table-relation-false-suppresses-rename-propagation.good.al | ||
| validate-table-relation-false-suppresses-rename-propagation.md | ||
| xrec-is-a-before-image-only-in-some-triggers.bad.al | ||
| xrec-is-a-before-image-only-in-some-triggers.good.al | ||
| xrec-is-a-before-image-only-in-some-triggers.md | ||