mirror of https://github.com/microsoft/BCQuality.git synced 2026-10-07 15:46:55 +01:00

Michael Dieringer 9e66377fa6 Ret bc-mcp: config-skabelon matcher broen + fejl svaelges ikke laengere

Live incident i aften: businesscentral MCP fejlede med et generisk
30-sekunders "connection timed out", ingen brugbar fejl. To reelle, adskilte
fejl fundet ved at teste direkte mod BC's endpoint:

1. ~/.bc-mcp.config.json havde "company": "CURABIS ApS" (Vist navn), men BC's
   faktiske Navn-felt er "Curabis ApS". BC svarede korrekt og hurtigt (400,
   under 200ms) - problemet var aldrig BC.

2. bc-mcp-bridge.js svaelgede det svar stille: en fejl-krop formateret som
   almindelig JSON, men markeret content-type text/event-stream, blev sendt
   til parseSSE() som kun leder efter "data:"-linjer - fandt ingen, returnerede
   en tom liste. Broen skrev derfor INGENTING, hverken stdout eller stderr, og
   Claude Code ventede blot sin egen 30-sekunders timeout ud.

Rettet:
- forward() tjekker nu !r.ok FOER content-type-forgrening, ubetinget - en
  fejlrespons naar aldrig parseSSE, uanset hvad serveren paastaar om sin
  egen content-type. Testet direkte mod det reproducerede scenarie: fejlen
  vises nu med det samme (5s test-vindue, ikke 30s timeout), med det fulde
  BC-fejlsvar synligt i baade stdout (JSON-RPC error) og stderr.
- bc-mcp.config.template.json matchede slet ikke broens faktiske felter
  (tenantId/baseUrl vs. broens tenant/company/configurationName) - enhver ny
  udvikler der udfyldte skabelonen efter dens egne feltnavne ville faa en
  config der intet virkede med. Rettet til de rigtige feltnavne, plus en
  eksplicit advarsel om Navn vs. Vist navn i company-feltet.
- Mode A's opsaetningsbesked (Step 3b) opdateret til at naevne alle
  placeholder-felter, ikke kun secret'en.
- To nye BCQuality-videnfiler dokumenterer begge fejl til fremtidig
  fejlsoegning.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

2026-08-01 00:18:37 +02:00

2.2 KiB

Raw Blame History

bc-version

domain

keywords

technologies

countries

application-area

all

mcp

businesscentral

mcp

bc-mcp-bridge

company

header

display-name

config

troubleshooting

mcp

all

BC MCP `Company` Header Must Be the Exact `Navn` Field, Not `Vist navn`

Description

~/.bc-mcp.config.json's company value is sent as the literal Company HTTP header to the BC MCP endpoint. It must exactly match the company's Navn field in Business Central's company list — not the Vist navn (display name) field. The two are often different strings for the same company, and BC's own company picker UI shows the display name more prominently, making it the natural (wrong) one to copy.

Incident (2026-07-31)

CURABIS's own businesscentral MCP server failed after "working all evening" with a generic client-side "connection timed out after 30000ms" — no useful error surfaced to the developer. Root cause: company was set to "CURABIS ApS" (the Vist navn), while BC's actual Navn field is "Curabis ApS". BC's own API rejected the mismatched header with a fast, clear 400 error — but bc-mcp-bridge.js had a separate bug (bc-mcp-bridge-must-surface-non-2xx-responses-before-sse-parsing, same incident) that swallowed the error body, turning a sub-200ms server error into a 30-second client-side hang with no diagnostic.

Verification

If businesscentral MCP fails, check BC's company list page (Virksomheder / Companies) and compare the Navn column — not Vist navn — against ~/.bc-mcp.config.json's company value, character for character. Do not assume the value that "looks right" from the picker UI is the one the API needs.

Anti-Pattern

// WRONG: copied from BC's company switcher, which shows Vist navn
{ "company": "CURABIS ApS" }

Compliant

// CORRECT: copied from the Navn column on the company list page
{ "company": "Curabis ApS" }

Scope

Every machine with ~/.bc-mcp.config.json configured — this is a machine-local file, not something Mode B can fix centrally. The template (bc-mcp.config.template.json) carries an explicit warning about this distinction as of 2026-07-31, but a machine already onboarded before that date needs its existing file checked manually.

2.2 KiB Raw Blame History

BC MCP Company Header Must Be the Exact Navn Field, Not Vist navn