alguidelines/content/docs/BestPractices/unnecessary-else/index.md

title	tags	categories
Unnecessary else	Readability	Best Practice

Created by Microsoft, Described by waldo

Description

else should not be used when the last action in the then part is an exit, break, skip, quit, error.

Bad code

    procedure SomeProcedure()
    begin
        if IsAdjmtBinCodeChanged() then
            Error(AdjmtBinCodeChangeNotAllowedErr, ...)
        else
            Error(BinCodeChangeNotAllowedErr, ...);
    end;

Good code

    procedure SomeProcedure()
    begin
        if IsAdjmtBinCodeChanged() then
            Error(AdjmtBinCodeChangeNotAllowedErr, ...)
        Error(BinCodeChangeNotAllowedErr, ...);
    end;

Discussions

You can find discussions on all "Best Practices" here.

If you don't find the discussion of this guideline, please feel free to create a new one with the same title as this article.