Microsoft/alguidelines
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Reorganizing

Browse source
This commit is contained in:
Jeremy Vyska 2021-10-30 22:09:32 +02:00
parent a4f6467d78
commit f4886ee235
326 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

29
content/NAVPatterns/3-cal-coding-guidelines/design/with-scope-name-collision/index.md Normal file
View file

@ -0,0 +1,29 @@
+++
title = "WITH Scope Name Collision"
weight = 1450
+++
Do not use the WITH scope when it has a variable whose name is the same as a local variable. This can lead to wrong code assumptions.
**Given that **"Contract Type" is a field on table ServiceContractHeader, then in the following example there is a parameter name clash with the field name. Which one will be used?
Bad code
PROCEDURE InsertData@1("Contract Type"@1000 : Option...);
...
BEGIN
...
WITH ServiceContractHeader DO BEGIN
...
DimMgt.InsertServContractDim(...,"Contract Type","Contract No.",0,...);
END;
Good code
PROCEDURE InsertData@1(ContractType@1000 : Option...);
...
BEGIN
...
WITH ServiceContractHeader DO BEGIN
...
DimMgt.InsertServContractDim(...,ContractType,"Contract No.",0,...);
END;