Merge pull request #84 from microsoft/waldo/guidelineUnnecessaryElse
Unnecessary 'else'
This commit is contained in:
commit
99cbd91ba4
1 changed files with 38 additions and 0 deletions
|
|
@ -0,0 +1,38 @@
|
||||||
|
+++
|
||||||
|
title = "Unnecessary 'else'"
|
||||||
|
weight = 1270
|
||||||
|
+++
|
||||||
|
|
||||||
|
<_Created by Microsoft, Described by waldo_\>
|
||||||
|
|
||||||
|
## Description
|
||||||
|
`else` should not be used when the last action in the `then` part is an `exit`, `break`, `skip`, `quit`, `error`.
|
||||||
|
|
||||||
|
## Bad code
|
||||||
|
|
||||||
|
```al
|
||||||
|
procedure SomeProcedure()
|
||||||
|
begin
|
||||||
|
if IsAdjmtBinCodeChanged then
|
||||||
|
Error(AdjmtBinCodeChangeNotAllowedErr,...)
|
||||||
|
else
|
||||||
|
Error(BinCodeChangeNotAllowedErr,...);
|
||||||
|
end;
|
||||||
|
```
|
||||||
|
|
||||||
|
## Good code
|
||||||
|
```al
|
||||||
|
procedure SomeProcedure()
|
||||||
|
begin
|
||||||
|
if IsAdjmtBinCodeChanged then
|
||||||
|
Error(AdjmtBinCodeChangeNotAllowedErr,...)
|
||||||
|
Error(BinCodeChangeNotAllowedErr,...);
|
||||||
|
end;
|
||||||
|
```
|
||||||
|
|
||||||
|
|
||||||
|
## [Discussions](https://github.com/microsoft/alguidelines/discussions/categories/bc-best-practices?discussions_q=unnecessary+else+category%3A%22BC+Best+Practices%22)
|
||||||
|
|
||||||
|
You can find discussions on all "Best Practices" [here](https://github.com/microsoft/alguidelines/discussions/categories/bc-best-practices).
|
||||||
|
|
||||||
|
If you don't find the discussion of this guideline, please feel fee to create a new one with the same title as this article.
|
||||||
Loading…
Add table
Add a link
Reference in a new issue