From 47cb851e72b5a26052b5f7042a4620089c827cfa Mon Sep 17 00:00:00 2001 From: waldo1001 Date: Sat, 11 Dec 2021 14:07:37 +0100 Subject: [PATCH 1/2] Unnecessary 'else' --- .../Readability/unnecessary-else/index.md | 38 +++++++++++++++++++ 1 file changed, 38 insertions(+) create mode 100644 content/BCBestPractices/Readability/unnecessary-else/index.md diff --git a/content/BCBestPractices/Readability/unnecessary-else/index.md b/content/BCBestPractices/Readability/unnecessary-else/index.md new file mode 100644 index 00000000..de29e469 --- /dev/null +++ b/content/BCBestPractices/Readability/unnecessary-else/index.md @@ -0,0 +1,38 @@ ++++ +title = "Unnecessary 'else'" +weight = 1270 ++++ + +<_Created by Microsoft, Described by waldo_\> + +## Description +`else` should not be used when the last action in the `then` part is an `exit`, `break`, `skip`, `quite`, `error`. + +## Bad code + +```al + procedure SomeProcedure() + begin + if IsAdjmtBinCodeChanged then + Error(AdjmtBinCodeChangeNotAllowedErr,...) + else + Error(BinCodeChangeNotAllowedErr,...); + end; +``` + +## Good code +```al + procedure SomeProcedure() + begin + if IsAdjmtBinCodeChanged then + Error(AdjmtBinCodeChangeNotAllowedErr,...) + Error(BinCodeChangeNotAllowedErr,...); + end; +``` + + +## [Discussions](https://github.com/microsoft/alguidelines/discussions/categories/bc-best-practices?discussions_q=unnecessary+else+category%3A%22BC+Best+Practices%22) + +You can find discussions on all "Best Practices" [here](https://github.com/microsoft/alguidelines/discussions/categories/bc-best-practices). + +If you don't find the discussion of this guideline, please feel fee to create a new one with the same title as this article. \ No newline at end of file From 930383d6b58146590b422bff9fca82834ac6301f Mon Sep 17 00:00:00 2001 From: waldo1001 Date: Mon, 13 Dec 2021 17:09:19 +0100 Subject: [PATCH 2/2] Quite --- content/BCBestPractices/Readability/unnecessary-else/index.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/BCBestPractices/Readability/unnecessary-else/index.md b/content/BCBestPractices/Readability/unnecessary-else/index.md index de29e469..c3b0f301 100644 --- a/content/BCBestPractices/Readability/unnecessary-else/index.md +++ b/content/BCBestPractices/Readability/unnecessary-else/index.md @@ -6,7 +6,7 @@ weight = 1270 <_Created by Microsoft, Described by waldo_\> ## Description -`else` should not be used when the last action in the `then` part is an `exit`, `break`, `skip`, `quite`, `error`. +`else` should not be used when the last action in the `then` part is an `exit`, `break`, `skip`, `quit`, `error`. ## Bad code