Microsoft/alguidelines
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #84 from microsoft/waldo/guidelineUnnecessaryElse

Browse source 
Unnecessary 'else'
This commit is contained in:
Henrik Helgesen 2021-12-14 12:42:52 -08:00 • committed by GitHub
commit 99cbd91ba4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 38 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

38
content/BCBestPractices/Readability/unnecessary-else/index.md Normal file
View file

@ -0,0 +1,38 @@
+++
title = "Unnecessary 'else'"
weight = 1270
+++
<_Created by Microsoft, Described by waldo_\>
## Description
`else` should not be used when the last action in the `then` part is an `exit`, `break`, `skip`, `quit`, `error`.
## Bad code
```al
procedure SomeProcedure()
begin
if IsAdjmtBinCodeChanged then
Error(AdjmtBinCodeChangeNotAllowedErr,...)
else
Error(BinCodeChangeNotAllowedErr,...);
end;
```
## Good code
```al
procedure SomeProcedure()
begin
if IsAdjmtBinCodeChanged then
Error(AdjmtBinCodeChangeNotAllowedErr,...)
Error(BinCodeChangeNotAllowedErr,...);
end;
```
## [Discussions](https://github.com/microsoft/alguidelines/discussions/categories/bc-best-practices?discussions_q=unnecessary+else+category%3A%22BC+Best+Practices%22)
You can find discussions on all "Best Practices" [here](https://github.com/microsoft/alguidelines/discussions/categories/bc-best-practices).
If you don't find the discussion of this guideline, please feel fee to create a new one with the same title as this article.