mirror of
https://github.com/microsoft/BCQuality.git
synced 2026-08-06 09:26:52 +01:00
faeacb2484
Add 12 atomic knowledge articles under microsoft/knowledge/events covering general AL event-design best practices: IsHandled initialization and OnAfter preservation, appending new event parameters, position-based event naming, reusing/extending events, avoiding per-iteration publishing, Temp-prefixing temporary record parameters, unabbreviated parameter names, preferring the this keyword over IncludeSender, avoiding loosely typed parameters, not mutating existing event contracts, and not bypassing critical operations with IsHandled. Each article ships a .good.al and .bad.al demonstration sample (object IDs 50240-50296; not compiled by CI). Extend the al-events-review leaf Worklist with one targeted check per new rule. Additive only; no contract or wiring change (events leaf already wired). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
32 lines
1,021 B
AL
32 lines
1,021 B
AL
// Demonstration-only AL. Not compiled by CI; illustrates the article.
|
|
codeunit 50246 "OnAfter Preserve Bad Sample"
|
|
{
|
|
procedure ReleaseDocument(var SalesHeader: Record "Sales Header")
|
|
var
|
|
IsHandled: Boolean;
|
|
begin
|
|
IsHandled := false;
|
|
OnBeforeReleaseDocument(SalesHeader, IsHandled);
|
|
|
|
// Bug: returning here also skips OnAfterReleaseDocument below, so
|
|
// subscribers that rely on the after-event stop running whenever
|
|
// another extension handles the OnBefore.
|
|
if IsHandled then
|
|
exit;
|
|
|
|
SalesHeader.Status := SalesHeader.Status::Released;
|
|
SalesHeader.Modify(true);
|
|
|
|
OnAfterReleaseDocument(SalesHeader);
|
|
end;
|
|
|
|
[IntegrationEvent(false, false)]
|
|
local procedure OnBeforeReleaseDocument(var SalesHeader: Record "Sales Header"; var IsHandled: Boolean)
|
|
begin
|
|
end;
|
|
|
|
[IntegrationEvent(false, false)]
|
|
local procedure OnAfterReleaseDocument(var SalesHeader: Record "Sales Header")
|
|
begin
|
|
end;
|
|
}
|