mirror of
https://github.com/microsoft/BCQuality.git
synced 2026-08-06 09:26:52 +01:00
Add 12 atomic knowledge articles under microsoft/knowledge/events covering general AL event-design best practices: IsHandled initialization and OnAfter preservation, appending new event parameters, position-based event naming, reusing/extending events, avoiding per-iteration publishing, Temp-prefixing temporary record parameters, unabbreviated parameter names, preferring the this keyword over IncludeSender, avoiding loosely typed parameters, not mutating existing event contracts, and not bypassing critical operations with IsHandled. Each article ships a .good.al and .bad.al demonstration sample (object IDs 50240-50296; not compiled by CI). Extend the al-events-review leaf Worklist with one targeted check per new rule. Additive only; no contract or wiring change (events leaf already wired). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
31 lines
1.2 KiB
AL
31 lines
1.2 KiB
AL
// Demonstration-only AL. Not compiled by CI; illustrates the article.
|
|
codeunit 50241 "IsHandled Init Bad Sample"
|
|
{
|
|
procedure ApplyDiscounts(var SalesHeader: Record "Sales Header")
|
|
var
|
|
DiscountPct: Decimal;
|
|
IsHandled: Boolean;
|
|
begin
|
|
// IsHandled is never initialized before the first raise, so flow depends
|
|
// on the variable's default rather than an explicit, documented intent.
|
|
OnBeforeApplyHeaderDiscount(SalesHeader, DiscountPct, IsHandled);
|
|
if not IsHandled then
|
|
DiscountPct := 5;
|
|
|
|
// Bug: IsHandled is not reset. If the first subscriber set it true, the
|
|
// payment-discount default below is silently skipped too.
|
|
OnBeforeApplyPaymentDiscount(SalesHeader, DiscountPct, IsHandled);
|
|
if not IsHandled then
|
|
DiscountPct += 2;
|
|
end;
|
|
|
|
[IntegrationEvent(false, false)]
|
|
local procedure OnBeforeApplyHeaderDiscount(var SalesHeader: Record "Sales Header"; var DiscountPct: Decimal; var IsHandled: Boolean)
|
|
begin
|
|
end;
|
|
|
|
[IntegrationEvent(false, false)]
|
|
local procedure OnBeforeApplyPaymentDiscount(var SalesHeader: Record "Sales Header"; var DiscountPct: Decimal; var IsHandled: Boolean)
|
|
begin
|
|
end;
|
|
}
|