bcquality/microsoft/knowledge/events/do-not-publish-events-inside-loops.bad.al
Jesper Schulz-Wedde faeacb2484 Add 12 general AL event-design articles to events domain
Add 12 atomic knowledge articles under microsoft/knowledge/events covering
general AL event-design best practices: IsHandled initialization and OnAfter
preservation, appending new event parameters, position-based event naming,
reusing/extending events, avoiding per-iteration publishing, Temp-prefixing
temporary record parameters, unabbreviated parameter names, preferring the
this keyword over IncludeSender, avoiding loosely typed parameters, not
mutating existing event contracts, and not bypassing critical operations
with IsHandled. Each article ships a .good.al and .bad.al demonstration
sample (object IDs 50240-50296; not compiled by CI). Extend the
al-events-review leaf Worklist with one targeted check per new rule.

Additive only; no contract or wiring change (events leaf already wired).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-06-25 11:58:59 +02:00

22 lines
802 B
AL

// Demonstration-only AL. Not compiled by CI; illustrates the article.
codeunit 50266 "Loop Event Bad Sample"
{
procedure ProcessLines(var SalesLine: Record "Sales Line")
begin
if SalesLine.FindSet() then
repeat
// Anti-pattern: an event raised on every iteration. Each
// subscriber runs once per line, so the cost scales with the
// row count and large batches can time out.
OnProcessLine(SalesLine);
SalesLine."Line Amount" := SalesLine.Quantity * SalesLine."Unit Price";
SalesLine.Modify(true);
until SalesLine.Next() = 0;
end;
[IntegrationEvent(false, false)]
local procedure OnProcessLine(var SalesLine: Record "Sales Line")
begin
end;
}