bcquality/microsoft/skills/review
Michael Dieringer cc7c1f2ee0 Address Jesper Schulz-Wedde's review on PR #156
- Rename 3 articles so their .good.al/.bad.al companion stems match
  (do-not-change-primary-key, testfield-required-setup-field,
  al-identifiers-english), fixing the R14 orphan-sample errors.
- do-not-change-primary-key.good.al: include Flow in the new table's
  own primary key so it actually models the discriminating dimension.
- al-build-output-must-not-pollute-project-root.md: drop the
  unsubstantiated AL0197 causal claim and the non-existent
  al.outputPath setting; reframe as build-artifact hygiene sourced
  from ALTool --outfolder / al_build outputPath.
- prefer-email-module.md: Email Message is Codeunit 8904, not a table;
  distinguish it from the underlying Sent/Outbox/Draft storage.
- file-datatype-saas.md: File.Open/Create/Read/Write fails to compile
  against a Cloud-scoped project, it does not compile and silently
  fail at runtime.
- namespace-must-be-verified-from-source.md: narrow to "resolve from
  the referenced object's source or symbols," since source-file line
  one is not the only authoritative source (symbol packages, comments
  before the namespace line).
- test-data-must-be-random-and-complete.md: drop "assume an empty
  database" and "collision-free" absolutes; reframe around
  independence from unrelated business records and reserving explicit
  values for scenario-defining inputs.
- binary-choice-must-be-boolean.md: scope to genuine true/false
  semantics, not mechanical two-member-enum-to-boolean conversion.
- document-report-word-layout.md: scope down to a sourced Microsoft
  Learn recommendation instead of an unconditional performance
  guarantee; cite the three Learn pages.
- Wire the new articles into their review skills' candidate-selection
  signals (file-datatype-saas, prefer-email-module,
  namespace-must-be-verified-from-source, var-parameters-require-an-
  addressable-variable) so they can actually enter a worklist.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-09-21 22:25:26 +02:00
..
al-appsource-review.md Address Jesper Schulz-Wedde's review on PR #156 2026-09-21 22:25:26 +02:00
al-breaking-changes-review.md Address Jesper Schulz-Wedde's review on PR #156 2026-09-21 22:25:26 +02:00
al-code-review.md Add source-verified Finance knowledge and review domain (#57) 2026-09-21 10:20:41 +02:00
al-data-modeling-review.md Add foundational AL developer knowledge (#195) 2026-09-21 10:15:39 +02:00
al-error-handling-review.md Add bounded knowledge retrieval (#179) 2026-09-11 12:35:31 +02:00
al-events-review.md knowledge(events): ChangeCompany leaves triggers and trigger-event subscribers running in the calling company (#152) 2026-09-15 12:34:28 +02:00
al-finance-review.md Add source-verified Finance knowledge and review domain (#57) 2026-09-21 10:20:41 +02:00
al-interfaces-review.md Add foundational AL developer knowledge (#195) 2026-09-21 10:15:39 +02:00
al-performance-review.md Add Job Queue reliability and scheduling guidance (#148) 2026-09-14 12:44:30 +02:00
al-privacy-review.md Add bounded knowledge retrieval (#179) 2026-09-11 12:35:31 +02:00
al-query-review.md Add query filter semantics guidance (#186) 2026-09-15 12:51:15 +02:00
al-reporting-review.md Add reporting review guidance and evaluation fixtures (#183) 2026-09-15 10:38:32 +02:00
al-scm-review.md Add SCM functional knowledge domain (#192) 2026-09-21 10:16:44 +02:00
al-security-review.md Add bounded knowledge retrieval (#179) 2026-09-11 12:35:31 +02:00
al-style-review.md Address Jesper Schulz-Wedde's review on PR #156 2026-09-21 22:25:26 +02:00
al-telemetry-review.md Add bounded knowledge retrieval (#179) 2026-09-11 12:35:31 +02:00
al-testing-review.md Add bounded knowledge retrieval (#179) 2026-09-11 12:35:31 +02:00
al-ui-review.md Add foundational AL developer knowledge (#195) 2026-09-21 10:15:39 +02:00
al-upgrade-review.md Add foundational AL developer knowledge (#195) 2026-09-21 10:15:39 +02:00
al-web-services-review.md Add bounded knowledge retrieval (#179) 2026-09-11 12:35:31 +02:00