mirror of
https://github.com/microsoft/BCQuality.git
synced 2026-10-05 14:46:55 +01:00
5016962b40
The article was rewritten to say a reset is required only when the value can carry over, and its H1 was updated to match, but three artefacts still carried the old "always initialize to false" premise: - The slug still read `initialize-ishandled-to-false-before-publishing`, which contradicts the body. The slug is not cosmetic: Build-KnowledgeIndex.ps1 ranks candidates on keywords, frontmatter dimensions, domain, path and title, so a stale path pushes selection back toward the behaviour this change narrows. Renamed to `reset-ishandled-only-when-the-value-can-carry-over`, following the existing precedent for conditional slugs such as `unreleased-symbol-change-is-not-a-breaking-change`. - Keywords still listed `initialization` and `deterministic` and omitted `false-positive`, the tag this repository uses for suppression articles. Replaced with `carry-over` and `loop-iteration` and added `false-positive`. - The good sample demonstrated only the "prefer separate fresh locals" clause and contained no reset at all, so the article's headline case had no positive example. It was also asymmetric with the bad sample, which gained a loop procedure showing a local that carries `true` into the next iteration. Added the matching loop procedure to the good sample: a local declared outside the loop is reset at the top of each iteration. That case cannot be solved by introducing another local, because AL has no block scope, so it is the only shape that demonstrates the reset the article still requires. It also gives the engine the correct `suggested-code` shape for the loop finding; without it the one-click fix adapted from the good sample would propose splitting the variable rather than adding one line. Also renamed the sample codeunits from "IsHandled Init ..." to "IsHandled Carry Over ...", and updated the two references to the old slug: the events leaf skill cue and the events pin in evaluation/review-fixtures.json. validate_frontmatter.py reports 0 errors; Test-ReviewFixtures.ps1 passes with 32 cases across 16 leaf domains and resolves the events fixture to the renamed article.
48 lines
1.8 KiB
AL
48 lines
1.8 KiB
AL
// Demonstration-only AL. Not compiled by CI; illustrates the article.
|
|
codeunit 50241 "IsHandled Carry Over Bad Sample"
|
|
{
|
|
procedure ApplyDiscounts(var SalesHeader: Record "Sales Header")
|
|
var
|
|
DiscountPct: Decimal;
|
|
IsHandled: Boolean;
|
|
begin
|
|
OnBeforeApplyHeaderDiscount(SalesHeader, DiscountPct, IsHandled);
|
|
if not IsHandled then
|
|
DiscountPct := 5;
|
|
|
|
// Bug: execution continues when the first event set IsHandled to true,
|
|
// and that stale value is passed to a different publisher.
|
|
OnBeforeApplyPaymentDiscount(SalesHeader, DiscountPct, IsHandled);
|
|
if not IsHandled then
|
|
DiscountPct += 2;
|
|
end;
|
|
|
|
procedure ApplyLineDiscounts(var SalesLine: Record "Sales Line")
|
|
var
|
|
LineIsHandled: Boolean;
|
|
begin
|
|
if SalesLine.FindSet() then
|
|
repeat
|
|
// Bug: the local initializes only once. A subscriber that handles
|
|
// one line leaves true for every later iteration.
|
|
OnBeforeApplyLineDiscount(SalesLine, LineIsHandled);
|
|
if not LineIsHandled then
|
|
SalesLine.Validate("Line Discount %", 5);
|
|
until SalesLine.Next() = 0;
|
|
end;
|
|
|
|
[IntegrationEvent(false, false)]
|
|
local procedure OnBeforeApplyHeaderDiscount(var SalesHeader: Record "Sales Header"; var DiscountPct: Decimal; var IsHandled: Boolean)
|
|
begin
|
|
end;
|
|
|
|
[IntegrationEvent(false, false)]
|
|
local procedure OnBeforeApplyPaymentDiscount(var SalesHeader: Record "Sales Header"; var DiscountPct: Decimal; var IsHandled: Boolean)
|
|
begin
|
|
end;
|
|
|
|
[IntegrationEvent(false, false)]
|
|
local procedure OnBeforeApplyLineDiscount(var SalesLine: Record "Sales Line"; var IsHandled: Boolean)
|
|
begin
|
|
end;
|
|
}
|