mirror of
https://github.com/microsoft/BCQuality.git
synced 2026-10-06 07:06:54 +01:00
a28ba1a1d7
- dimension-management-wiring.md/.good.al: split into the two distinct
models the article was conflating - master data (Default Dimension
records via ValidateDimValueCode/SaveDefaultDim) vs. transactional/
document data (a single Dimension Set ID assembled via AddDimSource +
GetDefaultDimID, verified against BCApps' ExchRateAdjmtProcess.Codeunit.al).
Added a compiling document-table example alongside the existing master
table one.
- Deleted api-page-flowfields-must-be-calcfields (.md/.good.al/.bad.al):
Microsoft's own FlowFields documentation states a FlowField used as a
control's direct source expression is automatically calculated on any
page - no API-page exception is documented, and none could be
reproduced.
- prefer-email-module.bad.al/.md: Codeunit Mail has no Send/GetErrorDesc
members; fixed to the real current 7-argument CreateMessage signature,
and corrected the claim that the legacy path "still runs" - its base
implementation no longer sends anything, only raises integration events.
- check-post-line-batch-pattern.md/.good.al: reframed from a universal
invariant to the standard shape, naming the real Gen./Item/CA/Res./Job/
Insurance/Mfg. Item/FA Jnl.-Check Line/-Post Line/-Post Batch codeunits
it's based on. Added the missing Check Line companion codeunit so the
good fixture is internally complete.
- test-data-must-be-random-and-complete.good.al: removed leftover
"collision-free" wording contradicting the already-corrected article text.
- fixed-choice-set-must-use-enum-not-integer.md: removed the reintroduced
state-count heuristic ("the line is the state count"), aligned with
binary-choice-must-be-boolean.md's semantics-based distinction.
- namespace-must-be-verified-from-source.md: removed the false claim that
the compiler and AL Language Server use different namespace-resolution
rules.
- intrinsic-al-functions-must-use-modern-casing.md: removed the unverified
claim that PascalCase is the VS Code formatter's default output.
Worklist completeness: added cues for the 8 rules in data-modeling,
testing, performance, and web-services that had none (Jesper's explicit
ask), plus the same gap in all 7 style rules from this PR (not explicitly
named this round, but the identical systemic issue) - 15 cues total across
al-data-modeling-review.md, al-testing-review.md, al-performance-review.md,
al-web-services-review.md, and al-style-review.md.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
||
|---|---|---|
| .. | ||
| api-enum-values-are-a-contract-by-name-not-ordinal.bad.al | ||
| api-enum-values-are-a-contract-by-name-not-ordinal.good.al | ||
| api-enum-values-are-a-contract-by-name-not-ordinal.md | ||
| api-page-key-fields-must-be-editable-on-insert.bad.al | ||
| api-page-key-fields-must-be-editable-on-insert.good.al | ||
| api-page-key-fields-must-be-editable-on-insert.md | ||
| disable-write-operations-on-read-only-api-pages.bad.al | ||
| disable-write-operations-on-read-only-api-pages.good.al | ||
| disable-write-operations-on-read-only-api-pages.md | ||
| expose-only-committed-data-from-api-reads.bad.al | ||
| expose-only-committed-data-from-api-reads.good.al | ||
| expose-only-committed-data-from-api-reads.md | ||
| expose-operations-as-bound-actions.bad.al | ||
| expose-operations-as-bound-actions.good.al | ||
| expose-operations-as-bound-actions.md | ||
| expose-systemid-as-the-api-key.bad.al | ||
| expose-systemid-as-the-api-key.good.al | ||
| expose-systemid-as-the-api-key.md | ||
| link-api-parts-on-systemid-and-set-multiplicity.bad.al | ||
| link-api-parts-on-systemid-and-set-multiplicity.good.al | ||
| link-api-parts-on-systemid-and-set-multiplicity.md | ||
| set-required-api-page-properties.bad.al | ||
| set-required-api-page-properties.good.al | ||
| set-required-api-page-properties.md | ||
| stored-derived-fields-must-not-be-exposed-directly.bad.al | ||
| stored-derived-fields-must-not-be-exposed-directly.good.al | ||
| stored-derived-fields-must-not-be-exposed-directly.md | ||
| version-apis-by-adding-not-mutating-published-versions.bad.al | ||
| version-apis-by-adding-not-mutating-published-versions.good.al | ||
| version-apis-by-adding-not-mutating-published-versions.md | ||
| webhook-eligibility-and-validationtoken-renewal.bad.al | ||
| webhook-eligibility-and-validationtoken-renewal.bad.js | ||
| webhook-eligibility-and-validationtoken-renewal.good.al | ||
| webhook-eligibility-and-validationtoken-renewal.good.js | ||
| webhook-eligibility-and-validationtoken-renewal.md | ||