mirror of
https://github.com/microsoft/BCQuality.git
synced 2026-10-05 14:46:55 +01:00
a28ba1a1d7
- dimension-management-wiring.md/.good.al: split into the two distinct
models the article was conflating - master data (Default Dimension
records via ValidateDimValueCode/SaveDefaultDim) vs. transactional/
document data (a single Dimension Set ID assembled via AddDimSource +
GetDefaultDimID, verified against BCApps' ExchRateAdjmtProcess.Codeunit.al).
Added a compiling document-table example alongside the existing master
table one.
- Deleted api-page-flowfields-must-be-calcfields (.md/.good.al/.bad.al):
Microsoft's own FlowFields documentation states a FlowField used as a
control's direct source expression is automatically calculated on any
page - no API-page exception is documented, and none could be
reproduced.
- prefer-email-module.bad.al/.md: Codeunit Mail has no Send/GetErrorDesc
members; fixed to the real current 7-argument CreateMessage signature,
and corrected the claim that the legacy path "still runs" - its base
implementation no longer sends anything, only raises integration events.
- check-post-line-batch-pattern.md/.good.al: reframed from a universal
invariant to the standard shape, naming the real Gen./Item/CA/Res./Job/
Insurance/Mfg. Item/FA Jnl.-Check Line/-Post Line/-Post Batch codeunits
it's based on. Added the missing Check Line companion codeunit so the
good fixture is internally complete.
- test-data-must-be-random-and-complete.good.al: removed leftover
"collision-free" wording contradicting the already-corrected article text.
- fixed-choice-set-must-use-enum-not-integer.md: removed the reintroduced
state-count heuristic ("the line is the state count"), aligned with
binary-choice-must-be-boolean.md's semantics-based distinction.
- namespace-must-be-verified-from-source.md: removed the false claim that
the compiler and AL Language Server use different namespace-resolution
rules.
- intrinsic-al-functions-must-use-modern-casing.md: removed the unverified
claim that PascalCase is the VS Code formatter's default output.
Worklist completeness: added cues for the 8 rules in data-modeling,
testing, performance, and web-services that had none (Jesper's explicit
ask), plus the same gap in all 7 style rules from this PR (not explicitly
named this round, but the identical systemic issue) - 15 cues total across
al-data-modeling-review.md, al-testing-review.md, al-performance-review.md,
al-web-services-review.md, and al-style-review.md.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
42 lines
1.2 KiB
AL
42 lines
1.2 KiB
AL
codeunit 50100 "Meter Jnl.-Check Line"
|
|
{
|
|
procedure CheckLine(var MeterJnlLine: Record "Meter Journal Line")
|
|
begin
|
|
// Reads setup/dimension data only, shows no UI beyond errors.
|
|
if MeterJnlLine.Quantity = 0 then
|
|
Error('Quantity must not be zero.');
|
|
end;
|
|
}
|
|
|
|
codeunit 50101 "Meter Jnl.-Post Line"
|
|
{
|
|
procedure PostLine(var MeterJnlLine: Record "Meter Journal Line")
|
|
var
|
|
MeterLedgEntry: Record "Meter Ledger Entry";
|
|
begin
|
|
// Writes exactly one ledger entry; never touches the Journal table.
|
|
MeterLedgEntry.Init();
|
|
MeterLedgEntry.TransferFields(MeterJnlLine);
|
|
MeterLedgEntry.Insert();
|
|
end;
|
|
}
|
|
|
|
codeunit 50102 "Meter Jnl.-Post Batch"
|
|
{
|
|
procedure PostBatch(var MeterJnlLine: Record "Meter Journal Line")
|
|
var
|
|
CheckLine: Codeunit "Meter Jnl.-Check Line";
|
|
PostLine: Codeunit "Meter Jnl.-Post Line";
|
|
begin
|
|
if MeterJnlLine.FindSet() then
|
|
repeat
|
|
CheckLine.CheckLine(MeterJnlLine);
|
|
until MeterJnlLine.Next() = 0;
|
|
|
|
if MeterJnlLine.FindSet() then
|
|
repeat
|
|
PostLine.PostLine(MeterJnlLine);
|
|
MeterJnlLine.Delete();
|
|
until MeterJnlLine.Next() = 0;
|
|
end;
|
|
}
|