mirror of
https://github.com/microsoft/BCQuality.git
synced 2026-10-05 22:56:55 +01:00
53ecca3204
The AL Guidelines mark `SetLoadFields` placed before `SetRange`/`SetFilter` as bad code and recommend filters first, while the BCQuality samples used the opposite order — contradictory guidance across two Microsoft repos. Per Learn (`Record.SetLoadFields`), "fields that are filtered upon are always loaded", so the two orders produce an identical projection. The upstream rule is a readability convention: keep `SetLoadFields` adjacent to the read it governs. - Reorder filters ahead of `SetLoadFields` in the six affected AL samples. - State the placement convention in the Best Practice section. - Record in Description that order does not change the projection, and that only a fieldless `SetLoadFields()` or a later overwriting call does. - Add an Anti Pattern note so review agents treat the reverse order as a readability observation, never a performance defect. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
17 lines
508 B
AL
17 lines
508 B
AL
codeunit 50100 "Item Reindex Queue"
|
|
{
|
|
procedure QueueItemsForReindex(CategoryCode: Code[20])
|
|
var
|
|
Item: Record Item;
|
|
ReindexQueue: Codeunit "Reindex Queue";
|
|
begin
|
|
// Only the primary key is used in the loop body; load nothing else.
|
|
Item.SetRange("Item Category Code", CategoryCode);
|
|
Item.SetLoadFields("No.");
|
|
|
|
if Item.FindSet() then
|
|
repeat
|
|
ReindexQueue.Enqueue(Item."No.");
|
|
until Item.Next() = 0;
|
|
end;
|
|
}
|