mirror of
https://github.com/microsoft/BCQuality.git
synced 2026-10-05 22:56:55 +01:00
4287233f80
* Strengthen review contracts and HTTP guidance - add outbound HttpClient transport and HTTP status review rules with paired fixtures`n- resolve layered action-skill overrides deterministically across enabled layers`n- validate findings reports and enforce measurable changed-fixture coverage * Add data handling and test isolation guidance - add SCM guidance for deriving base quantities through line unit-of-measure validation`n- add security guidance for parameterizing SetFilter with external text`n- add test isolation guidance for resetting per-test state before initialization guards`n- add web-service guidance for JSON null handling and invariant standard format 9`n- route and cover all five rules with paired evaluation fixtures * Fix findings report rollup validation * Validate findings report rollups * Enforce merged finding identity * Fix locationless finding deduplication * Reject conflicting merged corrections * Detect conflicting leaf corrections * Route HTTP error checks to canonical web-services knowledge Let the Error Handling leaf conditionally retrieve the existing HTTP owner articles, preserving applicability and exact-path provenance. Add deterministic source-contract and retrieval regressions without duplicating knowledge rules. Copilot-Session-Id: a92a7788-103e-4651-9b84-19e34caffb94 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: wenjiefan <wenjiefan@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Co-authored-by: Jesper Schulz-Wedde <jesper.schulzwedde@microsoft.com>
37 lines
1.3 KiB
YAML
37 lines
1.3 KiB
YAML
name: Validate AL review fixtures
|
|
|
|
on:
|
|
pull_request:
|
|
branches: [main]
|
|
push:
|
|
branches: [main]
|
|
|
|
jobs:
|
|
validate-review-fixtures:
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- name: Check out repository
|
|
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
|
|
with:
|
|
fetch-depth: 0
|
|
|
|
- name: Collect changed paths
|
|
shell: pwsh
|
|
env:
|
|
BASE_SHA: ${{ github.event.pull_request.base.sha || github.event.before }}
|
|
run: |
|
|
$paths = if (-not $env:BASE_SHA -or $env:BASE_SHA -match '^0+$') {
|
|
@(git diff-tree --no-commit-id --name-only -r $env:GITHUB_SHA)
|
|
} else {
|
|
@(git diff --name-only $env:BASE_SHA $env:GITHUB_SHA)
|
|
}
|
|
$paths | Set-Content -LiteralPath "$env:RUNNER_TEMP/changed-paths.txt" -Encoding utf8NoBOM
|
|
|
|
- name: Validate review evaluation corpus
|
|
shell: pwsh
|
|
run: |
|
|
./tools/Test-ReviewFixtures.ps1 -Root . `
|
|
-PrepareDirectory "$env:RUNNER_TEMP/bcquality-review-fixtures" `
|
|
-ChangedPathsFile "$env:RUNNER_TEMP/changed-paths.txt" `
|
|
-CoverageReportPath "$env:RUNNER_TEMP/review-coverage.json"
|
|
Get-Content -LiteralPath "$env:RUNNER_TEMP/review-coverage.json"
|