mirror of
https://github.com/microsoft/BCQuality.git
synced 2026-10-05 06:36:55 +01:00
07e324ddbc
Some checks failed
Validate knowledge index / validate-index (push) Has been cancelled
Validate AL review fixtures / validate-review-fixtures (push) Has been cancelled
Validate skill index and report schemas / validate-contract (push) Has been cancelled
Validate frontmatter and structure / validate (push) Has been cancelled
* Add Finance posting domain-knowledge pilot Adds three atomic domain-rule knowledge files under community/knowledge/finance/ as a pilot for Type-A (normative) Business Central domain knowledge: post through the posting engine, treat posted ledger entries as immutable, and treat the Dimension Set ID as the source of truth for dimensions. Includes a good/bad AL sample pair for the posting rule. These encode BC-specific invariants that LLMs reliably get wrong, fitting the existing remedial/atomic knowledge grain with no schema or contract changes. Passes the repo frontmatter validator and is discovered by the knowledge index. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Clarify editable operational fields on posted ledger entries Addresses review feedback from @JeremyVyska on PR #57: the immutability rule applies to financial content, not the whole entry. Reframes the Description around financial content and gives the operational-field exception (payment/application data, on-hold, applies-to, communication fields edited via CustEntry-Edit/VendEntry-Edit and the ledger entry pages) its own paragraph in Best Practice instead of understating it as a narrow set. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Expand Finance pilot into a source-verified review domain Move Finance knowledge to the Microsoft-owned layer, add nine scoped rules with eighteen AL samples, and register bounded Finance review with complete paired evaluation coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Fix Finance review applicability and ownership boundaries Remove application-area gating and later VAT-field dependencies, align dynamic shared conventions, separate SCM ownership, and keep journal examples focused on the intended invariant. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Remove logo branding (#194) Co-authored-by: Jesper Schulz-Wedde <jesper.schulzwedde@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Add title and description to README * Add foundational AL developer knowledge (#195) Co-authored-by: Jesper Schulz-Wedde <jesper.schulzwedde@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Clarify locale-safe DateFormula Evaluate inputs (#193) * Clarify locale-safe DateFormula Evaluate inputs Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Normalize DateFormula article sections Keep the analyzer-gap explanation in Description and its scoped probe evidence in References, without a novel Validation section. Normative guidance and fixtures are unchanged. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Jesper Schulz-Wedde <jesper.schulzwedde@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Add SCM functional knowledge domain (#192) * Add SCM functional knowledge domain Introduce nine source-backed rules with original AL sample pairs, bounded SCM review routing, and complete positive/clean evaluation coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Normalize SCM knowledge and review ownership Align article and AL sample conventions, keep BC facts separate from review mechanics, and clarify reciprocal Finance ownership without bespoke shared test assertions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Jesper Schulz-Wedde <jesper.schulzwedde@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Jesper Schulz-Wedde <jesper.schulzwedde@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
60 lines
2.7 KiB
AL
60 lines
2.7 KiB
AL
// Demonstration only; independently authored, not copied from BaseApp.
|
|
codeunit 50100 "Post Transfer Journal"
|
|
{
|
|
procedure PostTransferBatch(TemplateName: Code[10]; BatchName: Code[10])
|
|
var
|
|
JournalLine: Record "Gen. Journal Line";
|
|
LastGLEntry: Record "G/L Entry";
|
|
NextEntryNo: Integer;
|
|
begin
|
|
JournalLine.SetRange("Journal Template Name", TemplateName);
|
|
JournalLine.SetRange("Journal Batch Name", BatchName);
|
|
if JournalLine.Count() <> 1 then
|
|
Error(SingleTransferErr);
|
|
JournalLine.FindFirst();
|
|
JournalLine.TestField("Account Type", JournalLine."Account Type"::"G/L Account");
|
|
JournalLine.TestField("Bal. Account Type", JournalLine."Bal. Account Type"::"G/L Account");
|
|
JournalLine.TestField("Account No.");
|
|
JournalLine.TestField("Bal. Account No.");
|
|
JournalLine.TestField("Posting Date");
|
|
JournalLine.TestField("Document No.");
|
|
JournalLine.TestField(Amount);
|
|
JournalLine.TestField("Currency Code", '');
|
|
JournalLine.TestField("Gen. Posting Type", JournalLine."Gen. Posting Type"::" ");
|
|
JournalLine.TestField("Bal. Gen. Posting Type", JournalLine."Bal. Gen. Posting Type"::" ");
|
|
|
|
LastGLEntry.LockTable();
|
|
if LastGLEntry.FindLast() then
|
|
NextEntryNo := LastGLEntry."Entry No." + 1
|
|
else
|
|
NextEntryNo := 1;
|
|
InsertLedgerRow(JournalLine, NextEntryNo, JournalLine."Account No.", JournalLine.Amount);
|
|
InsertLedgerRow(JournalLine, NextEntryNo + 1, JournalLine."Bal. Account No.", -JournalLine.Amount);
|
|
end;
|
|
|
|
local procedure InsertLedgerRow(JournalLine: Record "Gen. Journal Line"; EntryNo: Integer; AccountNo: Code[20]; Amount: Decimal)
|
|
var
|
|
GLEntry: Record "G/L Entry";
|
|
begin
|
|
GLEntry.Init();
|
|
GLEntry."Entry No." := EntryNo;
|
|
GLEntry."G/L Account No." := AccountNo;
|
|
GLEntry."Posting Date" := JournalLine."Posting Date";
|
|
GLEntry."Document Type" := JournalLine."Document Type";
|
|
GLEntry."Document No." := JournalLine."Document No.";
|
|
GLEntry."Source Code" := JournalLine."Source Code";
|
|
GLEntry."Journal Batch Name" := JournalLine."Journal Batch Name";
|
|
GLEntry."Dimension Set ID" := JournalLine."Dimension Set ID";
|
|
GLEntry."Global Dimension 1 Code" := JournalLine."Shortcut Dimension 1 Code";
|
|
GLEntry."Global Dimension 2 Code" := JournalLine."Shortcut Dimension 2 Code";
|
|
GLEntry.Amount := Amount;
|
|
if Amount > 0 then
|
|
GLEntry."Debit Amount" := Amount
|
|
else
|
|
GLEntry."Credit Amount" := -Amount;
|
|
GLEntry.Insert(true);
|
|
end;
|
|
|
|
var
|
|
SingleTransferErr: Label 'Use a journal batch containing exactly one self-balancing G/L transfer.';
|
|
}
|