mirror of
https://github.com/microsoft/BCQuality.git
synced 2026-10-05 14:46:55 +01:00
67962727f6
Six carried-over threads: - api-page-least-privilege-write-access fixtures: added the mandatory EntityName/EntitySetName properties (AL0485). - pages-must-not-contain-business-logic fixtures: Sales Line has no "Total Amount" field; replaced with the real "Line Amount" (field 103). - test-feature-scenario-tags.good.al and test-one-when-per-test.good.al: CreatePriceHeader leaves a price list in Draft status, which price calculation ignores. Added Validate(Status, Active) + Modify before the sales line that depends on it. Verified Status field/enum against PriceListHeader.Table.al and PriceStatus.Enum.al in the BCApps clone. - exposed-objects-must-be-in-a-permission-set.md: a published codeunit is a SOAP endpoint (SOAP is deprecated), not OData - Page/Query are the OData object types. Corrected and pointed new integrations at API pages/queries instead. - al-error-handling-review.md: the log-writes-must-survive-rollback cue selected on Session.StartSession, which only appears in the compliant fix, never in the anti-pattern - the bad fixture could never be worklisted. Recued on the actual risk shape (log insert around a failed TryFunction/GetLastError* path, then raise/propagate), with StartSession as an explicit compliant discriminator instead. - page-design-must-match-bc-page-type-conventions.md: the enum value is NavigatePage, not Navigate; noted the type list is a selected subset, not an exhaustive PageType catalogue (PromptDialog, ConfigurationDialog, UserControlHost, XmlPort also exist, out of this article's scope). Four new correctness gaps: - release-must-update-app-version.md: "the version is the only identity" was backwards - id is the app's stable identity, version identifies a release/code-state of it. - defensive-vs-offensive-code-must-match-blast-radius.good.al: the "low blast radius" example had no else branch, so a failed Customer.Get() left the field at its prior/default value instead of the explicit chosen fallback the article claims to demonstrate. Added the else. - bcpt-scenarios-must-be-app-specific.good.al: InitTest and both measured StartScenario/EndScenario sections were empty/comment-only, so the "app-specific" fixture measured no actual work. Filled in a real, self-contained header+line creation path. - upgrade-tag-logic-must-not-nest-deeply.good.al: the flattened version dropped both safety conditions the bad fixture had (Discount % = 0, nonblank posting group), silently changing behavior instead of just removing nesting. Extracted the guarded update into a helper with both conditions preserved as early exits. Also converted this PR's remaining plain-backtick "See sample:" sample references (16 articles) to the READ-convention markdown-link form, matching the fix already made on #156/#158. Rebased onto upstream/main (conflicts in al-ui-review.md, al-style-review.md, al-upgrade-review.md against merged upstream PRs - all additive, both sides' worklist cues retained). |
||
|---|---|---|
| .. | ||
| bound-page-field-inherits-source-field-tooltip.md | ||
| caption-capitalization-noun-phrase-vs-sentence-phrase.good.al | ||
| caption-capitalization-noun-phrase-vs-sentence-phrase.md | ||
| control-add-in-accessibility-is-developer-responsibility.md | ||
| control-add-in-has-no-bc-color-tokens.md | ||
| control-addin-package-resource-ajax-needs-withcredentials.bad.js | ||
| control-addin-package-resource-ajax-needs-withcredentials.good.js | ||
| control-addin-package-resource-ajax-needs-withcredentials.md | ||
| control-addin-throttle-al-calls-and-payload-size.bad.js | ||
| control-addin-throttle-al-calls-and-payload-size.good.js | ||
| control-addin-throttle-al-calls-and-payload-size.md | ||
| cosmetic-styles-need-no-textual-context.md | ||
| default-descending-sort-on-historical-pages.bad.al | ||
| default-descending-sort-on-historical-pages.good.al | ||
| default-descending-sort-on-historical-pages.md | ||
| dropdown-fieldgroup-respects-lookup-page-visibility.bad.al | ||
| dropdown-fieldgroup-respects-lookup-page-visibility.good.al | ||
| dropdown-fieldgroup-respects-lookup-page-visibility.md | ||
| factbox-design.md | ||
| fasttab-field-importance.md | ||
| grid-data-table-heuristic.good.al | ||
| grid-data-table-heuristic.md | ||
| group-caption-quality-is-not-an-accessibility-issue.md | ||
| group-labeled-first-child-exception.bad.al | ||
| group-labeled-first-child-exception.good.al | ||
| group-labeled-first-child-exception.md | ||
| group-show-caption-false-outside-grid-is-not-a-violation.md | ||
| layout-table-with-captions-is-valid.md | ||
| no-nested-grids.bad.al | ||
| no-nested-grids.md | ||
| on-drill-down-on-non-editable-fields-renders-as-link.md | ||
| page-background-tasks.md | ||
| page-design-must-match-bc-page-type-conventions.bad.al | ||
| page-design-must-match-bc-page-type-conventions.good.al | ||
| page-design-must-match-bc-page-type-conventions.md | ||
| prefer-actionref-syntax-for-promoted-actions.md | ||
| promoted-action-groups.md | ||
| semantic-style-in-cuegroup-exception.good.al | ||
| semantic-style-in-cuegroup-exception.md | ||
| semantic-styles-need-independent-textual-meaning.bad.al | ||
| semantic-styles-need-independent-textual-meaning.good.al | ||
| semantic-styles-need-independent-textual-meaning.md | ||
| set-selection-filter-list-scope.bad.al | ||
| set-selection-filter-list-scope.good.al | ||
| set-selection-filter-list-scope.md | ||
| show-caption-false-allowed-on-non-editable-fields.good.al | ||
| show-caption-false-allowed-on-non-editable-fields.md | ||
| show-caption-in-promptdialog-prompt-area.good.al | ||
| show-caption-in-promptdialog-prompt-area.md | ||
| show-caption-in-repeater-allowed.good.al | ||
| show-caption-in-repeater-allowed.md | ||
| show-caption-on-editable-fields.bad.al | ||
| show-caption-on-editable-fields.good.al | ||
| show-caption-on-editable-fields.md | ||
| showmandatory-on-code-required-page-fields.bad.al | ||
| showmandatory-on-code-required-page-fields.good.al | ||
| showmandatory-on-code-required-page-fields.md | ||
| standalone-content-in-layout-table.good.al | ||
| standalone-content-in-layout-table.md | ||
| style-expr-text-vs-boolean.good.al | ||
| style-expr-text-vs-boolean.md | ||
| tabular-intent-requires-data-table-conditions.bad.al | ||
| tabular-intent-requires-data-table-conditions.md | ||
| updatepropagation-both-refreshes-main-page.bad.al | ||
| updatepropagation-both-refreshes-main-page.good.al | ||
| updatepropagation-both-refreshes-main-page.md | ||
| validate-request-page-input-in-onqueryclosepage.bad.al | ||
| validate-request-page-input-in-onqueryclosepage.good.al | ||
| validate-request-page-input-in-onqueryclosepage.md | ||