mirror of
https://github.com/microsoft/BCQuality.git
synced 2026-10-05 14:46:55 +01:00
- log-writes-must-survive-rollback.good.al: fixed invalid trigger OnRun(var Rec: ...) declaration; Rec is implicit when TableNo is set. - exposed-objects-must-be-in-a-permission-set.md: distinguished the three exposure mechanisms (page/query web service or API, codeunit published as a web service, [ServiceEnabled] bound action on a page) and their actual permission targets (page/query "..." = X vs codeunit "..." = X). - code-must-not-change-workdate.md: scoped from an absolute "never" to "not as a side effect of unrelated logic" - verified real WorkDate(x) setter usage in BCApps demo-data generators and test codeunits. - bcpt-scenarios-must-be-app-specific.md: SingleInstance and StartScenario/EndScenario reframed as context-dependent patterns, not mandatory requirements - BCPT Create Customer uses neither. - test-feature-scenario-tags.good.al/.bad.al: replaced the invented LibrarySales.CreateCustomerWithPrice/"Item Price Mgt." calls with a real, verified price-list-line test using Library - Sales/Library - Inventory/ Library - Price Calculation. - page-design-must-match-bc-page-type-conventions.md: scoped the missing UsageCategory anti-pattern to pages intended as searchable entry points. - defensive-vs-offensive-code-must-match-blast-radius.md/.good.al/.bad.al: replaced the VAT registration number "low blast radius" example with a genuinely cosmetic field (customer home page URL). - source-organized-by-feature-not-object-type.md: anti-pattern reframed as inconsistency with a repo's own convention, not the object-type scheme itself. - pictures-must-use-media-not-blob.md: removed leftover "image variants" wording contradicting the already-corrected MediaSet description. Proactively fixed while sweeping all fixtures for invented APIs: - given-blocks-must-cover-full-precondition-chain.bad.al: PostSalesOrder called with wrong arity and referenced an undeclared variable. - ui-test-codeunit-naming.good.al/.bad.al: replaced the same fake "Item Price Mgt."/TestPage "Item Price" with real Library - Sales calls and the real Customer Card TestPage. Worklist completeness: added review-skill cues for the 12 of 18 new rules that had none (al-appsource-review.md, al-data-modeling-review.md, al-error-handling-review.md, al-security-review.md, al-style-review.md x3, al-testing-review.md x2, al-ui-review.md, al-upgrade-review.md, al-web-services-review.md), and fixed test-feature-scenario-tags' cue, which only matched the compliant (tagged) shape instead of the anti-pattern (untagged/generic-named test). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
45 lines
1.5 KiB
AL
45 lines
1.5 KiB
AL
table 50100 "Sample Error Log Buffer"
|
|
{
|
|
TableType = Temporary;
|
|
fields
|
|
{
|
|
field(1; "Call Duration (ms)"; Integer) { }
|
|
field(2; "Error Message"; Text[250]) { }
|
|
}
|
|
}
|
|
|
|
codeunit 50100 "Sample Error Log Writer"
|
|
{
|
|
// TableNo makes OnRun receive the Record that Session.StartSession
|
|
// passes to the new session. This is the only data channel into that
|
|
// session — there is no shared memory with the caller's instance.
|
|
TableNo = "Sample Error Log Buffer";
|
|
|
|
trigger OnRun()
|
|
var
|
|
ErrorLogEntry: Record "Sample Error Log";
|
|
begin
|
|
ErrorLogEntry.Init();
|
|
ErrorLogEntry."Call Duration (ms)" := Rec."Call Duration (ms)";
|
|
ErrorLogEntry."Error Message" :=
|
|
CopyStr(Rec."Error Message", 1, MaxStrLen(ErrorLogEntry."Error Message"));
|
|
ErrorLogEntry.Insert(true);
|
|
Commit();
|
|
end;
|
|
}
|
|
|
|
// Caller side: populate the buffer record, then hand it to StartSession.
|
|
// The insert-and-commit above happens inside the started session, so it
|
|
// survives even if the caller's own transaction rolls back afterward.
|
|
codeunit 50101 "Sample Error Log Caller Excerpt"
|
|
{
|
|
procedure LogFailure(Duration: Integer; ErrorText: Text)
|
|
var
|
|
LogBuffer: Record "Sample Error Log Buffer" temporary;
|
|
SessionId: Integer;
|
|
begin
|
|
LogBuffer."Call Duration (ms)" := Duration;
|
|
LogBuffer."Error Message" := CopyStr(ErrorText, 1, MaxStrLen(LogBuffer."Error Message"));
|
|
Session.StartSession(SessionId, Codeunit::"Sample Error Log Writer", CompanyName, LogBuffer);
|
|
end;
|
|
}
|