mirror of
https://github.com/microsoft/BCQuality.git
synced 2026-10-05 14:46:55 +01:00
67962727f6
Six carried-over threads: - api-page-least-privilege-write-access fixtures: added the mandatory EntityName/EntitySetName properties (AL0485). - pages-must-not-contain-business-logic fixtures: Sales Line has no "Total Amount" field; replaced with the real "Line Amount" (field 103). - test-feature-scenario-tags.good.al and test-one-when-per-test.good.al: CreatePriceHeader leaves a price list in Draft status, which price calculation ignores. Added Validate(Status, Active) + Modify before the sales line that depends on it. Verified Status field/enum against PriceListHeader.Table.al and PriceStatus.Enum.al in the BCApps clone. - exposed-objects-must-be-in-a-permission-set.md: a published codeunit is a SOAP endpoint (SOAP is deprecated), not OData - Page/Query are the OData object types. Corrected and pointed new integrations at API pages/queries instead. - al-error-handling-review.md: the log-writes-must-survive-rollback cue selected on Session.StartSession, which only appears in the compliant fix, never in the anti-pattern - the bad fixture could never be worklisted. Recued on the actual risk shape (log insert around a failed TryFunction/GetLastError* path, then raise/propagate), with StartSession as an explicit compliant discriminator instead. - page-design-must-match-bc-page-type-conventions.md: the enum value is NavigatePage, not Navigate; noted the type list is a selected subset, not an exhaustive PageType catalogue (PromptDialog, ConfigurationDialog, UserControlHost, XmlPort also exist, out of this article's scope). Four new correctness gaps: - release-must-update-app-version.md: "the version is the only identity" was backwards - id is the app's stable identity, version identifies a release/code-state of it. - defensive-vs-offensive-code-must-match-blast-radius.good.al: the "low blast radius" example had no else branch, so a failed Customer.Get() left the field at its prior/default value instead of the explicit chosen fallback the article claims to demonstrate. Added the else. - bcpt-scenarios-must-be-app-specific.good.al: InitTest and both measured StartScenario/EndScenario sections were empty/comment-only, so the "app-specific" fixture measured no actual work. Filled in a real, self-contained header+line creation path. - upgrade-tag-logic-must-not-nest-deeply.good.al: the flattened version dropped both safety conditions the bad fixture had (Discount % = 0, nonblank posting group), silently changing behavior instead of just removing nesting. Extracted the guarded update into a helper with both conditions preserved as early exits. Also converted this PR's remaining plain-backtick "See sample:" sample references (16 articles) to the READ-convention markdown-link form, matching the fix already made on #156/#158. Rebased onto upstream/main (conflicts in al-ui-review.md, al-style-review.md, al-upgrade-review.md against merged upstream PRs - all additive, both sides' worklist cues retained). |
||
|---|---|---|
| .. | ||
| appversion-meaning-depends-on-execution-context.md | ||
| breaking-changes-only-on-tables-without-data.bad.al | ||
| breaking-changes-only-on-tables-without-data.good.al | ||
| breaking-changes-only-on-tables-without-data.md | ||
| check-only-triggers-do-not-migrate-data.bad.al | ||
| check-only-triggers-do-not-migrate-data.good.al | ||
| check-only-triggers-do-not-migrate-data.md | ||
| datatransfer-for-bulk-init.bad.al | ||
| datatransfer-for-bulk-init.good.al | ||
| datatransfer-for-bulk-init.md | ||
| datatransfer-skips-triggers-and-subscribers.bad.al | ||
| datatransfer-skips-triggers-and-subscribers.good.al | ||
| datatransfer-skips-triggers-and-subscribers.md | ||
| do-not-block-upgrade-on-data-errors.bad.al | ||
| do-not-block-upgrade-on-data-errors.good.al | ||
| do-not-block-upgrade-on-data-errors.md | ||
| enum-values-additive-at-end.bad.al | ||
| enum-values-additive-at-end.good.al | ||
| enum-values-additive-at-end.md | ||
| first-install-dataversion-zero-check.bad.al | ||
| first-install-dataversion-zero-check.good.al | ||
| first-install-dataversion-zero-check.md | ||
| guard-database-reads.bad.al | ||
| guard-database-reads.good.al | ||
| guard-database-reads.md | ||
| hybrid-migration-codeunits-not-standard-upgrade.md | ||
| initvalue-does-not-update-existing-rows.bad.al | ||
| initvalue-does-not-update-existing-rows.good.al | ||
| initvalue-does-not-update-existing-rows.md | ||
| install-and-upgrade-codeunits-have-no-order.bad.al | ||
| install-and-upgrade-codeunits-have-no-order.good.al | ||
| install-and-upgrade-codeunits-have-no-order.md | ||
| install-code-does-not-run-on-version-upgrade.bad.al | ||
| install-code-does-not-run-on-version-upgrade.good.al | ||
| install-code-does-not-run-on-version-upgrade.md | ||
| minimize-onvalidate-upgrade-triggers.bad.al | ||
| minimize-onvalidate-upgrade-triggers.good.al | ||
| minimize-onvalidate-upgrade-triggers.md | ||
| no-external-calls-in-upgrade.bad.al | ||
| no-external-calls-in-upgrade.good.al | ||
| no-external-calls-in-upgrade.md | ||
| obsolete-pending-to-removed-staging.bad.al | ||
| obsolete-pending-to-removed-staging.good.al | ||
| obsolete-pending-to-removed-staging.md | ||
| obsoletereason-need-not-restate-removal-version.md | ||
| obsoletion-requires-reason-and-tag.bad.al | ||
| obsoletion-requires-reason-and-tag.good.al | ||
| obsoletion-requires-reason-and-tag.md | ||
| register-upgrade-tags-with-subscribers.bad.al | ||
| register-upgrade-tags-with-subscribers.good.al | ||
| register-upgrade-tags-with-subscribers.md | ||
| skip-nonessential-work-via-execution-context.bad.al | ||
| skip-nonessential-work-via-execution-context.good.al | ||
| skip-nonessential-work-via-execution-context.md | ||
| triggers-call-helpers-not-implementations.bad.al | ||
| triggers-call-helpers-not-implementations.good.al | ||
| triggers-call-helpers-not-implementations.md | ||
| unreleased-schema-change-needs-no-upgrade-path.md | ||
| upgrade-codeunit-subtype.bad.al | ||
| upgrade-codeunit-subtype.good.al | ||
| upgrade-codeunit-subtype.md | ||
| upgrade-tag-logic-must-not-nest-deeply.bad.al | ||
| upgrade-tag-logic-must-not-nest-deeply.good.al | ||
| upgrade-tag-logic-must-not-nest-deeply.md | ||
| use-upgrade-tags-not-version-checks.bad.al | ||
| use-upgrade-tags-not-version-checks.good.al | ||
| use-upgrade-tags-not-version-checks.md | ||