mirror of
https://github.com/microsoft/BCQuality.git
synced 2026-10-05 14:46:55 +01:00
67962727f6
Six carried-over threads: - api-page-least-privilege-write-access fixtures: added the mandatory EntityName/EntitySetName properties (AL0485). - pages-must-not-contain-business-logic fixtures: Sales Line has no "Total Amount" field; replaced with the real "Line Amount" (field 103). - test-feature-scenario-tags.good.al and test-one-when-per-test.good.al: CreatePriceHeader leaves a price list in Draft status, which price calculation ignores. Added Validate(Status, Active) + Modify before the sales line that depends on it. Verified Status field/enum against PriceListHeader.Table.al and PriceStatus.Enum.al in the BCApps clone. - exposed-objects-must-be-in-a-permission-set.md: a published codeunit is a SOAP endpoint (SOAP is deprecated), not OData - Page/Query are the OData object types. Corrected and pointed new integrations at API pages/queries instead. - al-error-handling-review.md: the log-writes-must-survive-rollback cue selected on Session.StartSession, which only appears in the compliant fix, never in the anti-pattern - the bad fixture could never be worklisted. Recued on the actual risk shape (log insert around a failed TryFunction/GetLastError* path, then raise/propagate), with StartSession as an explicit compliant discriminator instead. - page-design-must-match-bc-page-type-conventions.md: the enum value is NavigatePage, not Navigate; noted the type list is a selected subset, not an exhaustive PageType catalogue (PromptDialog, ConfigurationDialog, UserControlHost, XmlPort also exist, out of this article's scope). Four new correctness gaps: - release-must-update-app-version.md: "the version is the only identity" was backwards - id is the app's stable identity, version identifies a release/code-state of it. - defensive-vs-offensive-code-must-match-blast-radius.good.al: the "low blast radius" example had no else branch, so a failed Customer.Get() left the field at its prior/default value instead of the explicit chosen fallback the article claims to demonstrate. Added the else. - bcpt-scenarios-must-be-app-specific.good.al: InitTest and both measured StartScenario/EndScenario sections were empty/comment-only, so the "app-specific" fixture measured no actual work. Filled in a real, self-contained header+line creation path. - upgrade-tag-logic-must-not-nest-deeply.good.al: the flattened version dropped both safety conditions the bad fixture had (Discount % = 0, nonblank posting group), silently changing behavior instead of just removing nesting. Extracted the guarded update into a helper with both conditions preserved as early exits. Also converted this PR's remaining plain-backtick "See sample:" sample references (16 articles) to the READ-convention markdown-link form, matching the fix already made on #156/#158. Rebased onto upstream/main (conflicts in al-ui-review.md, al-style-review.md, al-upgrade-review.md against merged upstream PRs - all additive, both sides' worklist cues retained). |
||
|---|---|---|
| .. | ||
| abouttitle-abouttext-teaching-tips.bad.al | ||
| abouttitle-abouttext-teaching-tips.good.al | ||
| abouttitle-abouttext-teaching-tips.md | ||
| al-comments-must-not-restate-what-code-already-shows.bad.al | ||
| al-comments-must-not-restate-what-code-already-shows.good.al | ||
| al-comments-must-not-restate-what-code-already-shows.md | ||
| api-page-camelcase-properties.bad.al | ||
| api-page-camelcase-properties.good.al | ||
| api-page-camelcase-properties.md | ||
| api-page-delayedinsert-true.bad.al | ||
| api-page-delayedinsert-true.good.al | ||
| api-page-delayedinsert-true.md | ||
| api-page-entity-naming-singular-plural.bad.al | ||
| api-page-entity-naming-singular-plural.good.al | ||
| api-page-entity-naming-singular-plural.md | ||
| api-page-version-format.bad.al | ||
| api-page-version-format.good.al | ||
| api-page-version-format.md | ||
| caption-required-on-page-fields.bad.al | ||
| caption-required-on-page-fields.good.al | ||
| caption-required-on-page-fields.md | ||
| case-action-on-line-after-possibility.bad.al | ||
| case-action-on-line-after-possibility.good.al | ||
| case-action-on-line-after-possibility.md | ||
| dateformula-evaluate-needs-language-independent-literals.bad.al | ||
| dateformula-evaluate-needs-language-independent-literals.good.al | ||
| dateformula-evaluate-needs-language-independent-literals.md | ||
| error-passes-parameters-directly-not-strsubstno.bad.al | ||
| error-passes-parameters-directly-not-strsubstno.good.al | ||
| error-passes-parameters-directly-not-strsubstno.md | ||
| fieldcaption-not-fieldname-in-user-messages.bad.al | ||
| fieldcaption-not-fieldname-in-user-messages.good.al | ||
| fieldcaption-not-fieldname-in-user-messages.md | ||
| file-name-object-type-pattern.md | ||
| label-comment-explains-placeholders.bad.al | ||
| label-comment-explains-placeholders.good.al | ||
| label-comment-explains-placeholders.md | ||
| label-locked-for-non-translatable.bad.al | ||
| label-locked-for-non-translatable.good.al | ||
| label-locked-for-non-translatable.md | ||
| labels-declared-at-object-scope.md | ||
| named-invocations-not-object-ids.bad.al | ||
| named-invocations-not-object-ids.good.al | ||
| named-invocations-not-object-ids.md | ||
| no-else-after-terminating-statement.bad.al | ||
| no-else-after-terminating-statement.good.al | ||
| no-else-after-terminating-statement.md | ||
| object-name-30-char-limit.md | ||
| page-name-must-match-source-table.md | ||
| pages-must-not-contain-business-logic.bad.al | ||
| pages-must-not-contain-business-logic.good.al | ||
| pages-must-not-contain-business-logic.md | ||
| source-organized-by-feature-not-object-type.md | ||
| temporary-variable-temp-prefix.bad.al | ||
| temporary-variable-temp-prefix.good.al | ||
| temporary-variable-temp-prefix.md | ||
| tooltip-required-on-page-fields.bad.al | ||
| tooltip-required-on-page-fields.good.al | ||
| tooltip-required-on-page-fields.md | ||
| xmldoc-for-public-library-procedures.md | ||