mirror of
https://github.com/microsoft/BCQuality.git
synced 2026-10-05 14:46:55 +01:00
67962727f6
Six carried-over threads: - api-page-least-privilege-write-access fixtures: added the mandatory EntityName/EntitySetName properties (AL0485). - pages-must-not-contain-business-logic fixtures: Sales Line has no "Total Amount" field; replaced with the real "Line Amount" (field 103). - test-feature-scenario-tags.good.al and test-one-when-per-test.good.al: CreatePriceHeader leaves a price list in Draft status, which price calculation ignores. Added Validate(Status, Active) + Modify before the sales line that depends on it. Verified Status field/enum against PriceListHeader.Table.al and PriceStatus.Enum.al in the BCApps clone. - exposed-objects-must-be-in-a-permission-set.md: a published codeunit is a SOAP endpoint (SOAP is deprecated), not OData - Page/Query are the OData object types. Corrected and pointed new integrations at API pages/queries instead. - al-error-handling-review.md: the log-writes-must-survive-rollback cue selected on Session.StartSession, which only appears in the compliant fix, never in the anti-pattern - the bad fixture could never be worklisted. Recued on the actual risk shape (log insert around a failed TryFunction/GetLastError* path, then raise/propagate), with StartSession as an explicit compliant discriminator instead. - page-design-must-match-bc-page-type-conventions.md: the enum value is NavigatePage, not Navigate; noted the type list is a selected subset, not an exhaustive PageType catalogue (PromptDialog, ConfigurationDialog, UserControlHost, XmlPort also exist, out of this article's scope). Four new correctness gaps: - release-must-update-app-version.md: "the version is the only identity" was backwards - id is the app's stable identity, version identifies a release/code-state of it. - defensive-vs-offensive-code-must-match-blast-radius.good.al: the "low blast radius" example had no else branch, so a failed Customer.Get() left the field at its prior/default value instead of the explicit chosen fallback the article claims to demonstrate. Added the else. - bcpt-scenarios-must-be-app-specific.good.al: InitTest and both measured StartScenario/EndScenario sections were empty/comment-only, so the "app-specific" fixture measured no actual work. Filled in a real, self-contained header+line creation path. - upgrade-tag-logic-must-not-nest-deeply.good.al: the flattened version dropped both safety conditions the bad fixture had (Discount % = 0, nonblank posting group), silently changing behavior instead of just removing nesting. Extracted the guarded update into a helper with both conditions preserved as early exits. Also converted this PR's remaining plain-backtick "See sample:" sample references (16 articles) to the READ-convention markdown-link form, matching the fix already made on #156/#158. Rebased onto upstream/main (conflicts in al-ui-review.md, al-style-review.md, al-upgrade-review.md against merged upstream PRs - all additive, both sides' worklist cues retained). |
||
|---|---|---|
| .. | ||
| check-blocked-in-referencing-code-not-in-master.bad.al | ||
| check-blocked-in-referencing-code-not-in-master.good.al | ||
| check-blocked-in-referencing-code-not-in-master.md | ||
| code-must-not-change-workdate.bad.al | ||
| code-must-not-change-workdate.good.al | ||
| code-must-not-change-workdate.md | ||
| initialize-document-defaults-in-initrecord.bad.al | ||
| initialize-document-defaults-in-initrecord.good.al | ||
| initialize-document-defaults-in-initrecord.md | ||
| insert-only-transfer-may-rely-on-caller-cleanup.md | ||
| master-table-no-from-number-series-in-oninsert.bad.al | ||
| master-table-no-from-number-series-in-oninsert.good.al | ||
| master-table-no-from-number-series-in-oninsert.md | ||
| owning-table-must-delete-dependents-in-ondelete.bad.al | ||
| owning-table-must-delete-dependents-in-ondelete.good.al | ||
| owning-table-must-delete-dependents-in-ondelete.md | ||
| pictures-must-use-media-not-blob.bad.al | ||
| pictures-must-use-media-not-blob.good.al | ||
| pictures-must-use-media-not-blob.md | ||
| round-direction-symbols-use-magnitude.bad.al | ||
| round-direction-symbols-use-magnitude.good.al | ||
| round-direction-symbols-use-magnitude.md | ||
| set-last-date-modified-in-onmodify-and-onrename.bad.al | ||
| set-last-date-modified-in-onmodify-and-onrename.good.al | ||
| set-last-date-modified-in-onmodify-and-onrename.md | ||
| setup-table-is-a-singleton.bad.al | ||
| setup-table-is-a-singleton.good.al | ||
| setup-table-is-a-singleton.md | ||
| share-mediaset-items-with-insert-not-field-assignment.bad.al | ||
| share-mediaset-items-with-insert-not-field-assignment.good.al | ||
| share-mediaset-items-with-insert-not-field-assignment.md | ||
| table-design-must-match-bc-table-type-conventions.bad.al | ||
| table-design-must-match-bc-table-type-conventions.good.al | ||
| table-design-must-match-bc-table-type-conventions.md | ||
| table-relation-extensions-are-additive-and-top-down.bad.al | ||
| table-relation-extensions-are-additive-and-top-down.good.al | ||
| table-relation-extensions-are-additive-and-top-down.md | ||
| transferfields-skip-type-mismatch-can-drop-data.bad.al | ||
| transferfields-skip-type-mismatch-can-drop-data.good.al | ||
| transferfields-skip-type-mismatch-can-drop-data.md | ||
| use-no-series-codeunit-not-noseriesmanagement.bad.al | ||
| use-no-series-codeunit-not-noseriesmanagement.good.al | ||
| use-no-series-codeunit-not-noseriesmanagement.md | ||
| validate-table-relation-false-suppresses-rename-propagation.bad.al | ||
| validate-table-relation-false-suppresses-rename-propagation.good.al | ||
| validate-table-relation-false-suppresses-rename-propagation.md | ||
| xrec-is-a-before-image-only-in-some-triggers.bad.al | ||
| xrec-is-a-before-image-only-in-some-triggers.good.al | ||
| xrec-is-a-before-image-only-in-some-triggers.md | ||