mirror of
https://github.com/microsoft/BCQuality.git
synced 2026-10-05 14:46:55 +01:00
4287233f80
* Strengthen review contracts and HTTP guidance - add outbound HttpClient transport and HTTP status review rules with paired fixtures`n- resolve layered action-skill overrides deterministically across enabled layers`n- validate findings reports and enforce measurable changed-fixture coverage * Add data handling and test isolation guidance - add SCM guidance for deriving base quantities through line unit-of-measure validation`n- add security guidance for parameterizing SetFilter with external text`n- add test isolation guidance for resetting per-test state before initialization guards`n- add web-service guidance for JSON null handling and invariant standard format 9`n- route and cover all five rules with paired evaluation fixtures * Fix findings report rollup validation * Validate findings report rollups * Enforce merged finding identity * Fix locationless finding deduplication * Reject conflicting merged corrections * Detect conflicting leaf corrections * Route HTTP error checks to canonical web-services knowledge Let the Error Handling leaf conditionally retrieve the existing HTTP owner articles, preserving applicability and exact-path provenance. Add deterministic source-contract and retrieval regressions without duplicating knowledge rules. Copilot-Session-Id: a92a7788-103e-4651-9b84-19e34caffb94 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: wenjiefan <wenjiefan@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Co-authored-by: Jesper Schulz-Wedde <jesper.schulzwedde@microsoft.com>
23 lines
No EOL
733 B
AL
23 lines
No EOL
733 B
AL
codeunit 50100 "HTTP Status Handling Good"
|
|
{
|
|
procedure GetCustomer(CustomerId: Guid): JsonObject
|
|
var
|
|
Client: HttpClient;
|
|
Response: HttpResponseMessage;
|
|
CustomerJson: JsonObject;
|
|
ResponseText: Text;
|
|
begin
|
|
if not Client.Get(
|
|
StrSubstNo('https://api.example.com/customers/%1', CustomerId),
|
|
Response)
|
|
then
|
|
Error('The customer service could not be reached.');
|
|
|
|
if not Response.IsSuccessStatusCode() then
|
|
Error('The customer service returned HTTP status %1.', Response.HttpStatusCode());
|
|
|
|
Response.Content().ReadAs(ResponseText);
|
|
CustomerJson.ReadFrom(ResponseText);
|
|
exit(CustomerJson);
|
|
end;
|
|
} |