mirror of
https://github.com/microsoft/BCQuality.git
synced 2026-10-05 14:46:55 +01:00
b7617fb48a
* knowledge(events): ChangeCompany leaves triggers and trigger-event subscribers running in the calling company ChangeCompany redirects only the data access of a record variable; Learn states that triggers still run in the current company. The database trigger events are raised on every database operation and only pass RunTrigger to the subscriber, so Insert(false) after ChangeCompany still runs every subscriber in the calling company. Generated code either assumes the record 'becomes' a target-company record, or switches RunTrigger off and hand-copies the trigger logic, leaving the subscribers writing to the wrong company; none of the tested runs reached StartSession with the company parameter. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * knowledge(events): qualify StartSession async semantics and fix concurrency-unsafe sample key Addresses PR #152 review: StartSession is a fire-and-forget background session (Ok reports only whether it started, not whether the codeunit succeeded, and errors inside it do not propagate), so the Best Practice now scopes the recommendation and calls out the durable status/error channel a synchronous-success write needs. The good sample's FindLast()+1 entry-number pattern raced under concurrent background sessions; switched to AutoIncrement, which the platform guarantees is unique across concurrent transactions. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * knowledge(events): serialize the setup-counter increment; promote article and wire the review skill PR #152 round 3 (JesperSchulz): - The good sample's OnAfterInsertEvent subscriber still raced on the shared "Transfer Setup Good" singleton (Get/increment/Modify); AutoIncrement only protected the request key. Added TransferSetup.LockTable() before Get() to serialize concurrent background sessions. - Promoted changecompany-runs-triggers-in-the-calling-company from community/knowledge/events/ to microsoft/knowledge/events/, and wired ChangeCompany/StartSession/RunTrigger tokens plus a targeted detection cue into microsoft/skills/review/al-events-review.md so a diff containing the anti-pattern reliably worklists this article, preserving the documented RunTrigger=false hand-off exception. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> --------- Co-authored-by: waldo1001 <12088142+waldo1001@users.noreply.github.com> Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| add-new-event-parameters-at-the-end.bad.al | ||
| add-new-event-parameters-at-the-end.good.al | ||
| add-new-event-parameters-at-the-end.md | ||
| adding-a-parameter-to-an-event-is-not-a-breaking-change.md | ||
| avoid-loosely-typed-event-parameters.bad.al | ||
| avoid-loosely-typed-event-parameters.good.al | ||
| avoid-loosely-typed-event-parameters.md | ||
| avoid-raising-events-inside-try-functions.bad.al | ||
| avoid-raising-events-inside-try-functions.good.al | ||
| avoid-raising-events-inside-try-functions.md | ||
| changecompany-runs-triggers-in-the-calling-company.bad.al | ||
| changecompany-runs-triggers-in-the-calling-company.good.al | ||
| changecompany-runs-triggers-in-the-calling-company.md | ||
| choose-static-vs-manual-subscribers-deliberately.bad.al | ||
| choose-static-vs-manual-subscribers-deliberately.good.al | ||
| choose-static-vs-manual-subscribers-deliberately.md | ||
| declare-event-publishers-local-or-internal.bad.al | ||
| declare-event-publishers-local-or-internal.good.al | ||
| declare-event-publishers-local-or-internal.md | ||
| do-not-add-ishandled-to-an-existing-event.bad.al | ||
| do-not-add-ishandled-to-an-existing-event.good.al | ||
| do-not-add-ishandled-to-an-existing-event.md | ||
| do-not-bypass-critical-operations-with-ishandled.bad.al | ||
| do-not-bypass-critical-operations-with-ishandled.good.al | ||
| do-not-bypass-critical-operations-with-ishandled.md | ||
| do-not-change-shipped-event-attribute-flags.bad.al | ||
| do-not-change-shipped-event-attribute-flags.good.al | ||
| do-not-change-shipped-event-attribute-flags.md | ||
| do-not-publish-events-inside-loops.bad.al | ||
| do-not-publish-events-inside-loops.good.al | ||
| do-not-publish-events-inside-loops.md | ||
| expose-process-context-via-manually-bound-flag.bad.al | ||
| expose-process-context-via-manually-bound-flag.good.al | ||
| expose-process-context-via-manually-bound-flag.md | ||
| name-event-parameters-without-abbreviations.bad.al | ||
| name-event-parameters-without-abbreviations.good.al | ||
| name-event-parameters-without-abbreviations.md | ||
| name-events-by-publisher-position.bad.al | ||
| name-events-by-publisher-position.good.al | ||
| name-events-by-publisher-position.md | ||
| prefer-reusing-or-extending-existing-events.bad.al | ||
| prefer-reusing-or-extending-existing-events.good.al | ||
| prefer-reusing-or-extending-existing-events.md | ||
| prefer-this-over-includesender-in-codeunit-events.bad.al | ||
| prefer-this-over-includesender-in-codeunit-events.good.al | ||
| prefer-this-over-includesender-in-codeunit-events.md | ||
| prefix-temporary-record-event-parameters-with-temp.bad.al | ||
| prefix-temporary-record-event-parameters-with-temp.good.al | ||
| prefix-temporary-record-event-parameters-with-temp.md | ||
| preserve-onafter-execution-when-ishandled-skips-the-body.bad.al | ||
| preserve-onafter-execution-when-ishandled-skips-the-body.good.al | ||
| preserve-onafter-execution-when-ishandled-skips-the-body.md | ||
| publish-thin-onbefore-onafter-integration-events.bad.al | ||
| publish-thin-onbefore-onafter-integration-events.good.al | ||
| publish-thin-onbefore-onafter-integration-events.md | ||
| reset-ishandled-only-when-the-value-can-carry-over.bad.al | ||
| reset-ishandled-only-when-the-value-can-carry-over.good.al | ||
| reset-ishandled-only-when-the-value-can-carry-over.md | ||
| treat-local-and-internal-events-as-subscriber-contracts.bad.al | ||
| treat-local-and-internal-events-as-subscriber-contracts.good.al | ||
| treat-local-and-internal-events-as-subscriber-contracts.md | ||
| use-ishandled-to-make-base-behaviour-overridable.bad.al | ||
| use-ishandled-to-make-base-behaviour-overridable.good.al | ||
| use-ishandled-to-make-base-behaviour-overridable.md | ||