mirror of
https://github.com/microsoft/BCQuality.git
synced 2026-10-05 06:36:55 +01:00
07e324ddbc
Some checks failed
Validate knowledge index / validate-index (push) Has been cancelled
Validate AL review fixtures / validate-review-fixtures (push) Has been cancelled
Validate skill index and report schemas / validate-contract (push) Has been cancelled
Validate frontmatter and structure / validate (push) Has been cancelled
* Add Finance posting domain-knowledge pilot Adds three atomic domain-rule knowledge files under community/knowledge/finance/ as a pilot for Type-A (normative) Business Central domain knowledge: post through the posting engine, treat posted ledger entries as immutable, and treat the Dimension Set ID as the source of truth for dimensions. Includes a good/bad AL sample pair for the posting rule. These encode BC-specific invariants that LLMs reliably get wrong, fitting the existing remedial/atomic knowledge grain with no schema or contract changes. Passes the repo frontmatter validator and is discovered by the knowledge index. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Clarify editable operational fields on posted ledger entries Addresses review feedback from @JeremyVyska on PR #57: the immutability rule applies to financial content, not the whole entry. Reframes the Description around financial content and gives the operational-field exception (payment/application data, on-hold, applies-to, communication fields edited via CustEntry-Edit/VendEntry-Edit and the ledger entry pages) its own paragraph in Best Practice instead of understating it as a narrow set. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Expand Finance pilot into a source-verified review domain Move Finance knowledge to the Microsoft-owned layer, add nine scoped rules with eighteen AL samples, and register bounded Finance review with complete paired evaluation coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Fix Finance review applicability and ownership boundaries Remove application-area gating and later VAT-field dependencies, align dynamic shared conventions, separate SCM ownership, and keep journal examples focused on the intended invariant. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Remove logo branding (#194) Co-authored-by: Jesper Schulz-Wedde <jesper.schulzwedde@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Add title and description to README * Add foundational AL developer knowledge (#195) Co-authored-by: Jesper Schulz-Wedde <jesper.schulzwedde@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Clarify locale-safe DateFormula Evaluate inputs (#193) * Clarify locale-safe DateFormula Evaluate inputs Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Normalize DateFormula article sections Keep the analyzer-gap explanation in Description and its scoped probe evidence in References, without a novel Validation section. Normative guidance and fixtures are unchanged. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Jesper Schulz-Wedde <jesper.schulzwedde@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Add SCM functional knowledge domain (#192) * Add SCM functional knowledge domain Introduce nine source-backed rules with original AL sample pairs, bounded SCM review routing, and complete positive/clean evaluation coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Normalize SCM knowledge and review ownership Align article and AL sample conventions, keep BC facts separate from review mechanics, and clarify reciprocal Finance ownership without bespoke shared test assertions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Jesper Schulz-Wedde <jesper.schulzwedde@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Jesper Schulz-Wedde <jesper.schulzwedde@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
53 lines
2.5 KiB
AL
53 lines
2.5 KiB
AL
// Demonstration only; independently authored, not copied from BaseApp.
|
|
codeunit 50107 "Post Journal Allocation"
|
|
{
|
|
procedure PostAllocation(TemplateName: Code[10]; BatchName: Code[10]; DebitAccount: Code[20]; CreditAccount: Code[20]; PostingDate: Date)
|
|
var
|
|
JournalTemplate: Record "Gen. Journal Template";
|
|
JournalBatch: Record "Gen. Journal Batch";
|
|
JournalLine: Record "Gen. Journal Line";
|
|
LineToPost: Record "Gen. Journal Line";
|
|
PostLine: Codeunit "Gen. Jnl.-Post Line";
|
|
begin
|
|
JournalTemplate.Get(TemplateName);
|
|
JournalTemplate.TestField(Recurring, false);
|
|
JournalTemplate.TestField("Force Doc. Balance", true);
|
|
JournalTemplate.TestField("Source Code");
|
|
JournalBatch.Get(TemplateName, BatchName);
|
|
JournalBatch.TestField("No. Series", '');
|
|
JournalBatch.TestField("Posting No. Series", '');
|
|
JournalLine.SetRange("Journal Template Name", TemplateName);
|
|
JournalLine.SetRange("Journal Batch Name", BatchName);
|
|
if not JournalLine.IsEmpty() then
|
|
Error(EmptyBatchErr);
|
|
|
|
AddAllocationLine(JournalTemplate, BatchName, 10000, DebitAccount, PostingDate, 'ALLOC-A', 90);
|
|
AddAllocationLine(JournalTemplate, BatchName, 20000, CreditAccount, PostingDate, 'ALLOC-B', -90);
|
|
JournalLine.FindSet();
|
|
repeat
|
|
LineToPost := JournalLine;
|
|
PostLine.RunWithCheck(LineToPost);
|
|
until JournalLine.Next() = 0;
|
|
end;
|
|
|
|
local procedure AddAllocationLine(JournalTemplate: Record "Gen. Journal Template"; BatchName: Code[10]; LineNo: Integer; AccountNo: Code[20]; PostingDate: Date; DocumentNo: Code[20]; LineAmount: Decimal)
|
|
var
|
|
JournalLine: Record "Gen. Journal Line";
|
|
begin
|
|
JournalLine.Init();
|
|
JournalLine."Journal Template Name" := JournalTemplate.Name;
|
|
JournalLine."Journal Batch Name" := BatchName;
|
|
JournalLine."Line No." := LineNo;
|
|
JournalLine."Source Code" := JournalTemplate."Source Code";
|
|
JournalLine.Validate("Posting Date", PostingDate);
|
|
JournalLine.Validate("Document No.", DocumentNo);
|
|
JournalLine.Validate("Account Type", JournalLine."Account Type"::"G/L Account");
|
|
JournalLine.Validate("Account No.", AccountNo);
|
|
JournalLine.Validate("Gen. Posting Type", JournalLine."Gen. Posting Type"::" ");
|
|
JournalLine.Validate(Amount, LineAmount);
|
|
JournalLine.Insert(true);
|
|
end;
|
|
|
|
var
|
|
EmptyBatchErr: Label 'Use an empty journal batch for this allocation.';
|
|
}
|