bcquality/microsoft/skills/review
Jesper Schulz-Wedde 51597068b1
Add bounded knowledge retrieval (#179)
* Add bounded knowledge retrieval

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 0d8b7764-f15a-49ea-8d50-d9147334f8af

* Fix bc-version overflow and pathless-row identity in bounded retrieval

Catalog matching compared an Int32 -BCVersion against a bigint range bound.
PowerShell coerces the right operand to the left operand's type, so a bound
wider than Int32 threw a conversion error and failed the whole domain catalog
rather than the single row. Metadata validation already accepts such bounds,
so compare as bigint on both sides.

The shared pager built its oversized-row message with $row.path, which
throws under Set-StrictMode -Version Latest when a row carries no path,
replacing the explicit bound failure with a property-lookup error. Resolve the
path defensively for dictionary and object rows so the offset-based fallback
is reachable.

Both paths gain regression coverage that fails without these fixes.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Jesper Schulz-Wedde <jesper.schulzwedde@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 0d8b7764-f15a-49ea-8d50-d9147334f8af
2026-09-11 12:35:31 +02:00
..
al-appsource-review.md Add bounded knowledge retrieval (#179) 2026-09-11 12:35:31 +02:00
al-breaking-changes-review.md Add bounded knowledge retrieval (#179) 2026-09-11 12:35:31 +02:00
al-code-review.md Add bounded knowledge retrieval (#179) 2026-09-11 12:35:31 +02:00
al-data-modeling-review.md Add bounded knowledge retrieval (#179) 2026-09-11 12:35:31 +02:00
al-error-handling-review.md Add bounded knowledge retrieval (#179) 2026-09-11 12:35:31 +02:00
al-events-review.md Add bounded knowledge retrieval (#179) 2026-09-11 12:35:31 +02:00
al-interfaces-review.md Add bounded knowledge retrieval (#179) 2026-09-11 12:35:31 +02:00
al-performance-review.md Add bounded knowledge retrieval (#179) 2026-09-11 12:35:31 +02:00
al-privacy-review.md Add bounded knowledge retrieval (#179) 2026-09-11 12:35:31 +02:00
al-query-review.md Add bounded knowledge retrieval (#179) 2026-09-11 12:35:31 +02:00
al-security-review.md Add bounded knowledge retrieval (#179) 2026-09-11 12:35:31 +02:00
al-style-review.md Add bounded knowledge retrieval (#179) 2026-09-11 12:35:31 +02:00
al-telemetry-review.md Add bounded knowledge retrieval (#179) 2026-09-11 12:35:31 +02:00
al-testing-review.md Add bounded knowledge retrieval (#179) 2026-09-11 12:35:31 +02:00
al-ui-review.md Add bounded knowledge retrieval (#179) 2026-09-11 12:35:31 +02:00
al-upgrade-review.md Add bounded knowledge retrieval (#179) 2026-09-11 12:35:31 +02:00
al-web-services-review.md Add bounded knowledge retrieval (#179) 2026-09-11 12:35:31 +02:00