mirror of
https://github.com/microsoft/BCQuality.git
synced 2026-10-05 06:36:55 +01:00
43c9d5319c
- api-page-key-fields-must-be-editable-on-insert.good.al and stored-derived-fields-must-not-be-exposed-directly.good.al: both were writable API pages missing DelayedInsert = true, contradicting this repo's own api-page-delayedinsert-true rule - the canonical "good" samples were teaching code BCQuality itself flags. - dimension-management-wiring.good.al: UpdateDimensionSetID exited early when Customer.Get failed, leaving the previous customer's shortcut dimension and Dimension Set ID in place - the same staleness bug the InheritFromDimSetID = 0 fix (from the prior review round) was meant to prevent, just triggered by a failed lookup instead of a successful one. Now clears the shortcut field and recomputes with an empty source list on a failed lookup too, so GetDefaultDimID correctly returns an empty Dimension Set ID instead of never running.
89 lines
3.1 KiB
AL
89 lines
3.1 KiB
AL
// Master data: Default Dimension records, no Dimension Set ID field.
|
|
table 50100 "Course"
|
|
{
|
|
fields
|
|
{
|
|
field(1; "No."; Code[20]) { }
|
|
field(10; "Global Dimension 1 Code"; Code[20])
|
|
{
|
|
CaptionClass = '1,1,1';
|
|
TableRelation = "Dimension Value".Code where(
|
|
"Global Dimension No." = const(1), Blocked = const(false));
|
|
|
|
trigger OnValidate()
|
|
var
|
|
DimMgt: Codeunit DimensionManagement;
|
|
begin
|
|
DimMgt.ValidateDimValueCode(1, "Global Dimension 1 Code");
|
|
DimMgt.SaveDefaultDim(Database::Course, "No.", 1, "Global Dimension 1 Code");
|
|
end;
|
|
}
|
|
}
|
|
|
|
trigger OnDelete()
|
|
var
|
|
DimMgt: Codeunit DimensionManagement;
|
|
begin
|
|
DimMgt.DeleteDefaultDim(Database::Course, "No.");
|
|
end;
|
|
}
|
|
|
|
// Transactional/document data: a single Dimension Set ID, inherited from the
|
|
// related master record and overridable via shortcut dimension fields.
|
|
table 50101 "Course Registration Header"
|
|
{
|
|
fields
|
|
{
|
|
field(1; "No."; Code[20]) { }
|
|
field(2; "Customer No."; Code[20])
|
|
{
|
|
TableRelation = Customer;
|
|
|
|
trigger OnValidate()
|
|
begin
|
|
UpdateDimensionSetID();
|
|
end;
|
|
}
|
|
field(10; "Shortcut Dimension 1 Code"; Code[20])
|
|
{
|
|
CaptionClass = '1,1,1';
|
|
TableRelation = "Dimension Value".Code where(
|
|
"Global Dimension No." = const(1), Blocked = const(false));
|
|
|
|
trigger OnValidate()
|
|
var
|
|
DimMgt: Codeunit DimensionManagement;
|
|
begin
|
|
DimMgt.ValidateShortcutDimValues(1, "Shortcut Dimension 1 Code", "Dimension Set ID");
|
|
end;
|
|
}
|
|
field(480; "Dimension Set ID"; Integer)
|
|
{
|
|
Editable = false;
|
|
TableRelation = "Dimension Set Entry"."Dimension Set ID";
|
|
}
|
|
}
|
|
|
|
local procedure UpdateDimensionSetID()
|
|
var
|
|
Customer: Record Customer;
|
|
DimMgt: Codeunit DimensionManagement;
|
|
DefaultDimSource: List of [Dictionary of [Integer, Code[20]]];
|
|
GlobalDim2Code: Code[20];
|
|
begin
|
|
// Recompute from scratch (InheritFromDimSetID = 0) whether or not the
|
|
// customer lookup succeeds. Passing the existing "Dimension Set ID"
|
|
// here would inherit dimensions from whichever record the document
|
|
// was previously linked to, and exiting early on a failed Get would
|
|
// leave that same stale data in place — both defeat the point of
|
|
// this procedure. Clearing the shortcut field and recomputing with
|
|
// an empty source list (when the customer doesn't exist) correctly
|
|
// clears the document's dimensions instead of leaving old ones.
|
|
"Shortcut Dimension 1 Code" := '';
|
|
if Customer.Get("Customer No.") then
|
|
DimMgt.AddDimSource(DefaultDimSource, Database::Customer, "Customer No.");
|
|
"Dimension Set ID" :=
|
|
DimMgt.GetDefaultDimID(
|
|
DefaultDimSource, '', "Shortcut Dimension 1 Code", GlobalDim2Code, 0, 0);
|
|
end;
|
|
}
|