mirror of
https://github.com/microsoft/BCQuality.git
synced 2026-10-05 14:46:55 +01:00
3842ef7138
- log-writes-must-survive-rollback.good.al: fixed invalid trigger OnRun(var Rec: ...) declaration; Rec is implicit when TableNo is set. - exposed-objects-must-be-in-a-permission-set.md: distinguished the three exposure mechanisms (page/query web service or API, codeunit published as a web service, [ServiceEnabled] bound action on a page) and their actual permission targets (page/query "..." = X vs codeunit "..." = X). - code-must-not-change-workdate.md: scoped from an absolute "never" to "not as a side effect of unrelated logic" - verified real WorkDate(x) setter usage in BCApps demo-data generators and test codeunits. - bcpt-scenarios-must-be-app-specific.md: SingleInstance and StartScenario/EndScenario reframed as context-dependent patterns, not mandatory requirements - BCPT Create Customer uses neither. - test-feature-scenario-tags.good.al/.bad.al: replaced the invented LibrarySales.CreateCustomerWithPrice/"Item Price Mgt." calls with a real, verified price-list-line test using Library - Sales/Library - Inventory/ Library - Price Calculation. - page-design-must-match-bc-page-type-conventions.md: scoped the missing UsageCategory anti-pattern to pages intended as searchable entry points. - defensive-vs-offensive-code-must-match-blast-radius.md/.good.al/.bad.al: replaced the VAT registration number "low blast radius" example with a genuinely cosmetic field (customer home page URL). - source-organized-by-feature-not-object-type.md: anti-pattern reframed as inconsistency with a repo's own convention, not the object-type scheme itself. - pictures-must-use-media-not-blob.md: removed leftover "image variants" wording contradicting the already-corrected MediaSet description. Proactively fixed while sweeping all fixtures for invented APIs: - given-blocks-must-cover-full-precondition-chain.bad.al: PostSalesOrder called with wrong arity and referenced an undeclared variable. - ui-test-codeunit-naming.good.al/.bad.al: replaced the same fake "Item Price Mgt."/TestPage "Item Price" with real Library - Sales calls and the real Customer Card TestPage. Worklist completeness: added review-skill cues for the 12 of 18 new rules that had none (al-appsource-review.md, al-data-modeling-review.md, al-error-handling-review.md, al-security-review.md, al-style-review.md x3, al-testing-review.md x2, al-ui-review.md, al-upgrade-review.md, al-web-services-review.md), and fixed test-feature-scenario-tags' cue, which only matched the compliant (tagged) shape instead of the anti-pattern (untagged/generic-named test). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| bound-page-field-inherits-source-field-tooltip.md | ||
| caption-capitalization-noun-phrase-vs-sentence-phrase.good.al | ||
| caption-capitalization-noun-phrase-vs-sentence-phrase.md | ||
| control-add-in-accessibility-is-developer-responsibility.md | ||
| control-add-in-has-no-bc-color-tokens.md | ||
| control-addin-package-resource-ajax-needs-withcredentials.bad.js | ||
| control-addin-package-resource-ajax-needs-withcredentials.good.js | ||
| control-addin-package-resource-ajax-needs-withcredentials.md | ||
| control-addin-throttle-al-calls-and-payload-size.bad.js | ||
| control-addin-throttle-al-calls-and-payload-size.good.js | ||
| control-addin-throttle-al-calls-and-payload-size.md | ||
| cosmetic-styles-need-no-textual-context.md | ||
| default-descending-sort-on-historical-pages.bad.al | ||
| default-descending-sort-on-historical-pages.good.al | ||
| default-descending-sort-on-historical-pages.md | ||
| dropdown-fieldgroup-respects-lookup-page-visibility.bad.al | ||
| dropdown-fieldgroup-respects-lookup-page-visibility.good.al | ||
| dropdown-fieldgroup-respects-lookup-page-visibility.md | ||
| factbox-design.md | ||
| fasttab-field-importance.md | ||
| grid-data-table-heuristic.good.al | ||
| grid-data-table-heuristic.md | ||
| group-caption-quality-is-not-an-accessibility-issue.md | ||
| group-labeled-first-child-exception.bad.al | ||
| group-labeled-first-child-exception.good.al | ||
| group-labeled-first-child-exception.md | ||
| group-show-caption-false-outside-grid-is-not-a-violation.md | ||
| layout-table-with-captions-is-valid.md | ||
| no-nested-grids.bad.al | ||
| no-nested-grids.md | ||
| on-drill-down-on-non-editable-fields-renders-as-link.md | ||
| page-background-tasks.md | ||
| page-design-must-match-bc-page-type-conventions.bad.al | ||
| page-design-must-match-bc-page-type-conventions.good.al | ||
| page-design-must-match-bc-page-type-conventions.md | ||
| prefer-actionref-syntax-for-promoted-actions.md | ||
| promoted-action-groups.md | ||
| semantic-style-in-cuegroup-exception.good.al | ||
| semantic-style-in-cuegroup-exception.md | ||
| semantic-styles-need-independent-textual-meaning.bad.al | ||
| semantic-styles-need-independent-textual-meaning.good.al | ||
| semantic-styles-need-independent-textual-meaning.md | ||
| set-selection-filter-list-scope.bad.al | ||
| set-selection-filter-list-scope.good.al | ||
| set-selection-filter-list-scope.md | ||
| show-caption-false-allowed-on-non-editable-fields.good.al | ||
| show-caption-false-allowed-on-non-editable-fields.md | ||
| show-caption-in-promptdialog-prompt-area.good.al | ||
| show-caption-in-promptdialog-prompt-area.md | ||
| show-caption-in-repeater-allowed.good.al | ||
| show-caption-in-repeater-allowed.md | ||
| show-caption-on-editable-fields.bad.al | ||
| show-caption-on-editable-fields.good.al | ||
| show-caption-on-editable-fields.md | ||
| showmandatory-on-code-required-page-fields.bad.al | ||
| showmandatory-on-code-required-page-fields.good.al | ||
| showmandatory-on-code-required-page-fields.md | ||
| standalone-content-in-layout-table.good.al | ||
| standalone-content-in-layout-table.md | ||
| style-expr-text-vs-boolean.good.al | ||
| style-expr-text-vs-boolean.md | ||
| tabular-intent-requires-data-table-conditions.bad.al | ||
| tabular-intent-requires-data-table-conditions.md | ||
| updatepropagation-both-refreshes-main-page.bad.al | ||
| updatepropagation-both-refreshes-main-page.good.al | ||
| updatepropagation-both-refreshes-main-page.md | ||
| validate-request-page-input-in-onqueryclosepage.bad.al | ||
| validate-request-page-input-in-onqueryclosepage.good.al | ||
| validate-request-page-input-in-onqueryclosepage.md | ||