mirror of
https://github.com/microsoft/BCQuality.git
synced 2026-10-05 06:36:55 +01:00
3842ef7138
- log-writes-must-survive-rollback.good.al: fixed invalid trigger OnRun(var Rec: ...) declaration; Rec is implicit when TableNo is set. - exposed-objects-must-be-in-a-permission-set.md: distinguished the three exposure mechanisms (page/query web service or API, codeunit published as a web service, [ServiceEnabled] bound action on a page) and their actual permission targets (page/query "..." = X vs codeunit "..." = X). - code-must-not-change-workdate.md: scoped from an absolute "never" to "not as a side effect of unrelated logic" - verified real WorkDate(x) setter usage in BCApps demo-data generators and test codeunits. - bcpt-scenarios-must-be-app-specific.md: SingleInstance and StartScenario/EndScenario reframed as context-dependent patterns, not mandatory requirements - BCPT Create Customer uses neither. - test-feature-scenario-tags.good.al/.bad.al: replaced the invented LibrarySales.CreateCustomerWithPrice/"Item Price Mgt." calls with a real, verified price-list-line test using Library - Sales/Library - Inventory/ Library - Price Calculation. - page-design-must-match-bc-page-type-conventions.md: scoped the missing UsageCategory anti-pattern to pages intended as searchable entry points. - defensive-vs-offensive-code-must-match-blast-radius.md/.good.al/.bad.al: replaced the VAT registration number "low blast radius" example with a genuinely cosmetic field (customer home page URL). - source-organized-by-feature-not-object-type.md: anti-pattern reframed as inconsistency with a repo's own convention, not the object-type scheme itself. - pictures-must-use-media-not-blob.md: removed leftover "image variants" wording contradicting the already-corrected MediaSet description. Proactively fixed while sweeping all fixtures for invented APIs: - given-blocks-must-cover-full-precondition-chain.bad.al: PostSalesOrder called with wrong arity and referenced an undeclared variable. - ui-test-codeunit-naming.good.al/.bad.al: replaced the same fake "Item Price Mgt."/TestPage "Item Price" with real Library - Sales calls and the real Customer Card TestPage. Worklist completeness: added review-skill cues for the 12 of 18 new rules that had none (al-appsource-review.md, al-data-modeling-review.md, al-error-handling-review.md, al-security-review.md, al-style-review.md x3, al-testing-review.md x2, al-ui-review.md, al-upgrade-review.md, al-web-services-review.md), and fixed test-feature-scenario-tags' cue, which only matched the compliant (tagged) shape instead of the anti-pattern (untagged/generic-named test). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| asserterror-needs-expectederror-and-code.bad.al | ||
| asserterror-needs-expectederror-and-code.good.al | ||
| asserterror-needs-expectederror-and-code.md | ||
| bcpt-scenarios-must-be-app-specific.bad.al | ||
| bcpt-scenarios-must-be-app-specific.good.al | ||
| bcpt-scenarios-must-be-app-specific.md | ||
| given-blocks-must-cover-full-precondition-chain.bad.al | ||
| given-blocks-must-cover-full-precondition-chain.good.al | ||
| given-blocks-must-cover-full-precondition-chain.md | ||
| permission-tests-must-lower-the-execution-context.bad.al | ||
| permission-tests-must-lower-the-execution-context.good.al | ||
| permission-tests-must-lower-the-execution-context.md | ||
| test-feature-scenario-tags.bad.al | ||
| test-feature-scenario-tags.good.al | ||
| test-feature-scenario-tags.md | ||
| test-one-when-per-test.bad.al | ||
| test-one-when-per-test.good.al | ||
| test-one-when-per-test.md | ||
| testisolation-belongs-on-the-test-runner.bad.al | ||
| testisolation-belongs-on-the-test-runner.good.al | ||
| testisolation-belongs-on-the-test-runner.md | ||
| transactionmodel-attribute-governs-test-transactions.bad.al | ||
| transactionmodel-attribute-governs-test-transactions.good.al | ||
| transactionmodel-attribute-governs-test-transactions.md | ||
| ui-handlers-in-tests.bad.al | ||
| ui-handlers-in-tests.good.al | ||
| ui-handlers-in-tests.md | ||
| ui-test-codeunit-naming.bad.al | ||
| ui-test-codeunit-naming.good.al | ||
| ui-test-codeunit-naming.md | ||
| use-library-codeunits-for-test-fixtures.bad.al | ||
| use-library-codeunits-for-test-fixtures.good.al | ||
| use-library-codeunits-for-test-fixtures.md | ||