mirror of
https://github.com/microsoft/BCQuality.git
synced 2026-10-05 14:46:55 +01:00
3842ef7138
- log-writes-must-survive-rollback.good.al: fixed invalid trigger OnRun(var Rec: ...) declaration; Rec is implicit when TableNo is set. - exposed-objects-must-be-in-a-permission-set.md: distinguished the three exposure mechanisms (page/query web service or API, codeunit published as a web service, [ServiceEnabled] bound action on a page) and their actual permission targets (page/query "..." = X vs codeunit "..." = X). - code-must-not-change-workdate.md: scoped from an absolute "never" to "not as a side effect of unrelated logic" - verified real WorkDate(x) setter usage in BCApps demo-data generators and test codeunits. - bcpt-scenarios-must-be-app-specific.md: SingleInstance and StartScenario/EndScenario reframed as context-dependent patterns, not mandatory requirements - BCPT Create Customer uses neither. - test-feature-scenario-tags.good.al/.bad.al: replaced the invented LibrarySales.CreateCustomerWithPrice/"Item Price Mgt." calls with a real, verified price-list-line test using Library - Sales/Library - Inventory/ Library - Price Calculation. - page-design-must-match-bc-page-type-conventions.md: scoped the missing UsageCategory anti-pattern to pages intended as searchable entry points. - defensive-vs-offensive-code-must-match-blast-radius.md/.good.al/.bad.al: replaced the VAT registration number "low blast radius" example with a genuinely cosmetic field (customer home page URL). - source-organized-by-feature-not-object-type.md: anti-pattern reframed as inconsistency with a repo's own convention, not the object-type scheme itself. - pictures-must-use-media-not-blob.md: removed leftover "image variants" wording contradicting the already-corrected MediaSet description. Proactively fixed while sweeping all fixtures for invented APIs: - given-blocks-must-cover-full-precondition-chain.bad.al: PostSalesOrder called with wrong arity and referenced an undeclared variable. - ui-test-codeunit-naming.good.al/.bad.al: replaced the same fake "Item Price Mgt."/TestPage "Item Price" with real Library - Sales calls and the real Customer Card TestPage. Worklist completeness: added review-skill cues for the 12 of 18 new rules that had none (al-appsource-review.md, al-data-modeling-review.md, al-error-handling-review.md, al-security-review.md, al-style-review.md x3, al-testing-review.md x2, al-ui-review.md, al-upgrade-review.md, al-web-services-review.md), and fixed test-feature-scenario-tags' cue, which only matched the compliant (tagged) shape instead of the anti-pattern (untagged/generic-named test). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| abouttitle-abouttext-teaching-tips.bad.al | ||
| abouttitle-abouttext-teaching-tips.good.al | ||
| abouttitle-abouttext-teaching-tips.md | ||
| al-comments-must-not-restate-what-code-already-shows.bad.al | ||
| al-comments-must-not-restate-what-code-already-shows.good.al | ||
| al-comments-must-not-restate-what-code-already-shows.md | ||
| api-page-camelcase-properties.bad.al | ||
| api-page-camelcase-properties.good.al | ||
| api-page-camelcase-properties.md | ||
| api-page-delayedinsert-true.bad.al | ||
| api-page-delayedinsert-true.good.al | ||
| api-page-delayedinsert-true.md | ||
| api-page-entity-naming-singular-plural.bad.al | ||
| api-page-entity-naming-singular-plural.good.al | ||
| api-page-entity-naming-singular-plural.md | ||
| api-page-version-format.bad.al | ||
| api-page-version-format.good.al | ||
| api-page-version-format.md | ||
| caption-required-on-page-fields.bad.al | ||
| caption-required-on-page-fields.good.al | ||
| caption-required-on-page-fields.md | ||
| case-action-on-line-after-possibility.bad.al | ||
| case-action-on-line-after-possibility.good.al | ||
| case-action-on-line-after-possibility.md | ||
| dateformula-evaluate-needs-language-independent-literals.bad.al | ||
| dateformula-evaluate-needs-language-independent-literals.good.al | ||
| dateformula-evaluate-needs-language-independent-literals.md | ||
| error-passes-parameters-directly-not-strsubstno.bad.al | ||
| error-passes-parameters-directly-not-strsubstno.good.al | ||
| error-passes-parameters-directly-not-strsubstno.md | ||
| fieldcaption-not-fieldname-in-user-messages.bad.al | ||
| fieldcaption-not-fieldname-in-user-messages.good.al | ||
| fieldcaption-not-fieldname-in-user-messages.md | ||
| file-name-object-type-pattern.md | ||
| label-comment-explains-placeholders.bad.al | ||
| label-comment-explains-placeholders.good.al | ||
| label-comment-explains-placeholders.md | ||
| label-locked-for-non-translatable.bad.al | ||
| label-locked-for-non-translatable.good.al | ||
| label-locked-for-non-translatable.md | ||
| labels-declared-at-object-scope.md | ||
| named-invocations-not-object-ids.bad.al | ||
| named-invocations-not-object-ids.good.al | ||
| named-invocations-not-object-ids.md | ||
| no-else-after-terminating-statement.bad.al | ||
| no-else-after-terminating-statement.good.al | ||
| no-else-after-terminating-statement.md | ||
| object-name-30-char-limit.md | ||
| page-name-must-match-source-table.md | ||
| pages-must-not-contain-business-logic.bad.al | ||
| pages-must-not-contain-business-logic.good.al | ||
| pages-must-not-contain-business-logic.md | ||
| source-organized-by-feature-not-object-type.md | ||
| temporary-variable-temp-prefix.bad.al | ||
| temporary-variable-temp-prefix.good.al | ||
| temporary-variable-temp-prefix.md | ||
| tooltip-required-on-page-fields.bad.al | ||
| tooltip-required-on-page-fields.good.al | ||
| tooltip-required-on-page-fields.md | ||
| xmldoc-for-public-library-procedures.md | ||