mirror of
https://github.com/microsoft/BCQuality.git
synced 2026-08-06 17:36:53 +01:00
31b9949235
Driven by a parity comparison between BCAppsBCQuality PR #27 and BCAppsCampAIRHack PR #162 on byte-identical content: | | BCQuality | AIRHack | |--|--|--| | Total findings | 6 | 10 | | Performance | 0 | 4 | | Security | 0 | 5 | Standalone runs of al-security-review and al-performance-review against the SAME diff produced the expected matches (rimd-on-read-only via inherent-permissions-minimal-grant; redundant-Get via avoid-redundant-get-when-record-already-loaded). The miss in the live run is therefore not a knowledge-coverage gap and not a worklist filtering issue. It is attention dilution inside the al-code-review super-skill, which the model collapses into one rolled-up generation pass on real-size PRs. Changes: microsoft/skills/review/al-code-review.md - New 'Execution discipline (mandatory)' subsection in the Action step that explicitly forbids collapsing leaves into one shared reasoning pass and requires each sub-skill to walk its Source -> Relevance -> Worklist -> Action steps as its own iteration before the next leaf starts. - Self-review pass is now described as the final, mandatory iteration with a concrete candidate-category checklist (architecture-level smells, error-handling gaps, magic constants, privacy/telemetry, resource lifecycle). Returning zero agent findings on a real-size diff is explicitly defined as a defect. microsoft/skills/review/al-{security,performance,privacy,style, upgrade,ui}-review.md - Each leaf skill now states that when an unambiguous .good.al companion exists, findings[].suggested-code should carry the literal replacement for the source lines. Closes the one-click-suggestion gap created when BCQ#19 only updated al-code-review. microsoft/knowledge/security/case-must-handle-unknown-enum-values.{md, bad.al, good.al} - New article: case over a security-sensitive enum (Authentication Type, Authorization Mode, Identity Provider, Permission Scope, Encryption Algorithm) MUST have an else arm. Without it, an unknown enum value silently falls through and the security context never initialises. The bad sample is lifted from the SharePoint Graph helper that triggered the parity finding. microsoft/knowledge/performance/instream-length-unreliable-for-bc- streams.{md,bad,good} - New article: InStream.Length returns 0 / partial for HTTP-response streams and some file-API streams, breaking size-threshold branching in upload code. Bad sample is the simple-vs-chunked Graph upload pattern; good sample materialises into a Temp Blob first. Companion change: microsoft/BCAppsBCQuality#28 extends the orchestrator's bootstrap prompt with the same per-iteration execution discipline and adds a CI warning when a >5-file PR returns zero agent findings (regression signal). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> |
||
|---|---|---|
| .. | ||
| addloadfields-in-report-onpredataitem.bad.al | ||
| addloadfields-in-report-onpredataitem.good.al | ||
| addloadfields-in-report-onpredataitem.md | ||
| admin-and-migration-pages-tolerate-lower-perf.md | ||
| apply-filters-before-iterating.bad.al | ||
| apply-filters-before-iterating.good.al | ||
| apply-filters-before-iterating.md | ||
| apply-guards-before-get.bad.al | ||
| apply-guards-before-get.good.al | ||
| apply-guards-before-get.md | ||
| avoid-commit-inside-loops.bad.al | ||
| avoid-commit-inside-loops.good.al | ||
| avoid-commit-inside-loops.md | ||
| avoid-get-inside-loop-on-large-table.bad.al | ||
| avoid-get-inside-loop-on-large-table.good.al | ||
| avoid-get-inside-loop-on-large-table.md | ||
| avoid-recordref-in-hot-loop.bad.al | ||
| avoid-recordref-in-hot-loop.good.al | ||
| avoid-recordref-in-hot-loop.md | ||
| avoid-redundant-get-when-record-already-loaded.bad.al | ||
| avoid-redundant-get-when-record-already-loaded.good.al | ||
| avoid-redundant-get-when-record-already-loaded.md | ||
| avoid-user-prompts-inside-transactions.bad.al | ||
| avoid-user-prompts-inside-transactions.good.al | ||
| avoid-user-prompts-inside-transactions.md | ||
| calcsums-instead-of-calcfields-in-loop.bad.al | ||
| calcsums-instead-of-calcfields-in-loop.good.al | ||
| calcsums-instead-of-calcfields-in-loop.md | ||
| codeunit-run-as-atomic-sub-operation.bad.al | ||
| codeunit-run-as-atomic-sub-operation.good.al | ||
| codeunit-run-as-atomic-sub-operation.md | ||
| codeunit-run-requires-prior-commit-inside-transaction.bad.al | ||
| codeunit-run-requires-prior-commit-inside-transaction.good.al | ||
| codeunit-run-requires-prior-commit-inside-transaction.md | ||
| do-not-locktable-in-read-only-procedure.bad.al | ||
| do-not-locktable-in-read-only-procedure.good.al | ||
| do-not-locktable-in-read-only-procedure.md | ||
| do-not-modify-in-onaftergetrecord.bad.al | ||
| do-not-modify-in-onaftergetrecord.good.al | ||
| do-not-modify-in-onaftergetrecord.md | ||
| do-not-remove-sourcetabletemporary-from-api-page.bad.al | ||
| do-not-remove-sourcetabletemporary-from-api-page.good.al | ||
| do-not-remove-sourcetabletemporary-from-api-page.md | ||
| findset-true-applies-updlock-on-read.bad.al | ||
| findset-true-applies-updlock-on-read.good.al | ||
| findset-true-applies-updlock-on-read.md | ||
| flowfield-source-key-needs-sumindexfields.bad.al | ||
| flowfield-source-key-needs-sumindexfields.good.al | ||
| flowfield-source-key-needs-sumindexfields.md | ||
| guard-event-subscribers-before-db-call.bad.al | ||
| guard-event-subscribers-before-db-call.good.al | ||
| guard-event-subscribers-before-db-call.md | ||
| instream-length-unreliable-for-bc-streams.bad.al | ||
| instream-length-unreliable-for-bc-streams.good.al | ||
| instream-length-unreliable-for-bc-streams.md | ||
| maintainsqlindex-false-breaks-flowfield-sift.bad.al | ||
| maintainsqlindex-false-breaks-flowfield-sift.md | ||
| pair-findset-with-next-loop.bad.al | ||
| pair-findset-with-next-loop.good.al | ||
| pair-findset-with-next-loop.md | ||
| pass-false-to-insert-when-trigger-not-needed.good.al | ||
| pass-false-to-insert-when-trigger-not-needed.md | ||
| prefer-dictionary-over-temporary-table-for-lookups.md | ||
| prefer-modifyall-over-per-row-modify.bad.al | ||
| prefer-modifyall-over-per-row-modify.good.al | ||
| prefer-modifyall-over-per-row-modify.md | ||
| prefer-readisolation-over-locktable-for-reads.bad.al | ||
| prefer-readisolation-over-locktable-for-reads.good.al | ||
| prefer-readisolation-over-locktable-for-reads.md | ||
| production-scale-tables-warrant-extra-analysis.md | ||
| setcurrentkey-aligns-key-with-filters.good.al | ||
| setcurrentkey-aligns-key-with-filters.md | ||
| singleton-setup-tables-need-no-access-optimization.md | ||
| temporary-tables-have-no-database-cost.md | ||
| triggers-and-media-field-regress-modifyall.md | ||
| understand-implicit-transaction-boundary.md | ||
| use-get-instead-of-findfirst-on-full-primary-key.bad.al | ||
| use-get-instead-of-findfirst-on-full-primary-key.good.al | ||
| use-get-instead-of-findfirst-on-full-primary-key.md | ||
| use-isempty-for-existence-check.bad.al | ||
| use-isempty-for-existence-check.good.al | ||
| use-isempty-for-existence-check.md | ||
| use-setloadfields-for-partial-records.bad.al | ||
| use-setloadfields-for-partial-records.good.al | ||
| use-setloadfields-for-partial-records.md | ||
| use-textbuilder-for-string-concatenation-in-loops.md | ||
| use-tryfunction-for-error-catching-not-rollback.bad.al | ||
| use-tryfunction-for-error-catching-not-rollback.good.al | ||
| use-tryfunction-for-error-catching-not-rollback.md | ||