mirror of
https://github.com/microsoft/BCQuality.git
synced 2026-10-05 06:36:55 +01:00
31206f6616
Addresses microsoft/BCQuality#175 review feedback: - Extend al-data-modeling-review's entry gate/relevance scope and token list to recognize document actions, Navigate subscribers, Report Selection registration, price-calculation/price-source extensibility, TransferFields posting-cascade mirroring, and barcode font-provider usage - previously excluded before any worklist cue could run. - Fix document-print-and-email-actions-call-report-selections-directly: permit the legitimate stateless DocumentSendingProfile.TrySendToPrinter/ TrySendToEMail path; rework the bad fixture to load a configured profile instead of demonstrating a trivial blank-record no-op. - Fix extend-report-selection-usage-for-new-document-types: scope to the applicable single counterparty (ReportSelectionHandlerCZZ partitions strictly; only genuinely two-sided usages like Compensation need both), and add the page-facing usage-enum map/validate events alongside the filter-event subscription for full Document Layouts support. - Fix a stale field-citation in custom-document-dispatch-must-not-bypass- report-selections (Custom Report Layout Code is field 7, not part of the 19-26 email-configuration range). - Add deterministic positive/clean evaluation coverage (review-fixtures.json additionalArticles + Test-ReviewFixtures.ps1 support) so all 9 new good/bad pairs are actually exercised, not just present. - Add 4 new patterns: activate-new-price-calculation-handler-via- onfindsupportedsetup, extend-price-source-type-must-sync-document- subset-enum, new-price-source-must-add-candidate-and-trigger- recalculation, report-barcodes-must-use-barcode-module-and-production- font-name. All claims verified against live microsoft/BCApps source and Microsoft Learn. Validators: frontmatter 0/0, review-fixtures 52 cases/17 domains PASSED, knowledge-index 309 articles PASSED. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
59 lines
1.9 KiB
JSON
59 lines
1.9 KiB
JSON
{
|
|
"version": 2,
|
|
"selection": "first-paired-al-article",
|
|
"minimumExpectedRecall": 1.0,
|
|
"minimumCleanRate": 1.0,
|
|
"overrides": {
|
|
"agents": {
|
|
"article": "wire-all-three-agent-interfaces"
|
|
},
|
|
"appsource": {
|
|
"context": "AppSourceCop mandatoryAffixes is configured to ABC."
|
|
},
|
|
"breaking-changes": {
|
|
"article": "do-not-expose-sensitive-data-through-public-api"
|
|
},
|
|
"data-modeling": {
|
|
"article": "check-blocked-in-referencing-code-not-in-master",
|
|
"additionalArticles": [
|
|
"extend-report-selection-usage-for-new-document-types",
|
|
"document-print-and-email-actions-call-report-selections-directly",
|
|
"custom-document-dispatch-must-not-bypass-report-selections",
|
|
"transferfields-mirrored-fields-must-match-type-and-length",
|
|
"extend-find-entries-navigate-for-new-document-types",
|
|
"activate-new-price-calculation-handler-via-onfindsupportedsetup",
|
|
"extend-price-source-type-must-sync-document-subset-enum",
|
|
"new-price-source-must-add-candidate-and-trigger-recalculation",
|
|
"report-barcodes-must-use-barcode-module-and-production-font-name"
|
|
]
|
|
},
|
|
"events": {
|
|
"article": "reset-ishandled-only-when-the-value-can-carry-over"
|
|
},
|
|
"interfaces": {
|
|
"article": "set-defaultimplementation-on-enum"
|
|
},
|
|
"performance": {
|
|
"article": "use-isempty-for-existence-check"
|
|
},
|
|
"privacy": {
|
|
"article": "no-pii-in-telemetry-message-string"
|
|
},
|
|
"style": {
|
|
"article": "label-comment-explains-placeholders"
|
|
},
|
|
"telemetry": {
|
|
"article": "telemetry-event-id-stable-unique"
|
|
},
|
|
"testing": {
|
|
"article": "ui-handlers-in-tests"
|
|
},
|
|
"upgrade": {
|
|
"article": "initvalue-does-not-update-existing-rows",
|
|
"context": "The extended table existed in the previous app version and already contains rows."
|
|
},
|
|
"web-services": {
|
|
"article": "expose-systemid-as-the-api-key"
|
|
}
|
|
}
|
|
}
|