Microsoft/bcquality
1
0
Fork 0
mirror of https://github.com/microsoft/BCQuality.git synced 2026-10-05 22:56:55 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 4
bcquality/microsoft/skills/review
History
Michael Dieringer 26871856ee Address second round of Jesper Schulz-Wedde's review on PR #158 
- use-generateguid-for-unique-test-fixture-values.md/.good.al: documented
  each LibraryUtility helper's actual behavior, verified against
  LibraryUtility.Codeunit.al. GenerateRandomCode opens the target table as
  a temporary RecordRef, so despite taking TableNo it never checks real
  data. GenerateRandomXMLText performs no table lookup at all. Only
  GenerateRandomCodeWithLength/GenerateRandomCode20 (capped at Code[10]/
  Code[20]) genuinely verify against the real table. Fixture switched to
  GenerateRandomCodeWithLength where the comment claims verified
  uniqueness.
- al-testing-review.md: rewired the cue to catch the actual anti-pattern
  (hardcoded literals, hand-built uniqueness, short-field GUID truncation)
  instead of only matching the compliant GenerateGUID()+CopyStr shape;
  broadened tokens to include TestPage, Library - Utility, and
  .Visible()/.Enabled()/.Editable().
- al-data-modeling-review.md: restricted the Item Ledger Entry
  Last-Shipping-No. cue to sales combined posting; purchase combined
  posting is Receive+Invoice and uses different fields entirely.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-09-21 22:34:40 +02:00
..
al-appsource-review.md Add AL-focused AppSource validation guidance (#142) 2026-09-14 12:42:45 +02:00
al-breaking-changes-review.md Add bounded knowledge retrieval (#179) 2026-09-11 12:35:31 +02:00
al-code-review.md Add source-verified Finance knowledge and review domain (#57) 2026-09-21 10:20:41 +02:00
al-data-modeling-review.md Address second round of Jesper Schulz-Wedde's review on PR #158 2026-09-21 22:34:40 +02:00
al-error-handling-review.md Add bounded knowledge retrieval (#179) 2026-09-11 12:35:31 +02:00
al-events-review.md knowledge(events): ChangeCompany leaves triggers and trigger-event subscribers running in the calling company (#152) 2026-09-15 12:34:28 +02:00
al-finance-review.md Add source-verified Finance knowledge and review domain (#57) 2026-09-21 10:20:41 +02:00
al-interfaces-review.md Add foundational AL developer knowledge (#195) 2026-09-21 10:15:39 +02:00
al-performance-review.md Add Job Queue reliability and scheduling guidance (#148) 2026-09-14 12:44:30 +02:00
al-privacy-review.md Add bounded knowledge retrieval (#179) 2026-09-11 12:35:31 +02:00
al-query-review.md Add query filter semantics guidance (#186) 2026-09-15 12:51:15 +02:00
al-reporting-review.md Add reporting review guidance and evaluation fixtures (#183) 2026-09-15 10:38:32 +02:00
al-scm-review.md Add SCM functional knowledge domain (#192) 2026-09-21 10:16:44 +02:00
al-security-review.md Add bounded knowledge retrieval (#179) 2026-09-11 12:35:31 +02:00
al-style-review.md Clarify locale-safe DateFormula Evaluate inputs (#193) 2026-09-21 10:16:07 +02:00
al-telemetry-review.md Add bounded knowledge retrieval (#179) 2026-09-11 12:35:31 +02:00
al-testing-review.md Address second round of Jesper Schulz-Wedde's review on PR #158 2026-09-21 22:34:40 +02:00
al-ui-review.md Add foundational AL developer knowledge (#195) 2026-09-21 10:15:39 +02:00
al-upgrade-review.md Add foundational AL developer knowledge (#195) 2026-09-21 10:15:39 +02:00
al-web-services-review.md Add bounded knowledge retrieval (#179) 2026-09-11 12:35:31 +02:00