bcquality/microsoft/skills/review
Michael Dieringer 1392521a8e Address second round of Jesper Schulz-Wedde's review on PR #159
- commit-shared-test-fixture-inside-lazy-initialize.md: fundamentally
  rewritten. AutoCommit is the documented default TransactionModel, not
  AutoRollback. Explains the real mechanism (Commit() protects a fixture
  from the test method's own later deliberate rollback, per Codeunit.Run/
  TransactionModel-property semantics) and the TestIsolation dependency
  (Disabled/Codeunit survive across methods, Function does not). Fixtures
  rewritten to demonstrate the actual failure/success shape.
- transactionmodel-attribute-governs-test-transactions.md: now states the
  AutoCommit default explicitly and agrees with the article above, closing
  the contradiction Jesper flagged between the two testing articles.
- Deleted confirm-needs-strsubstno-before-confirmhandler-sees-substituted-text
  (.md/.good.al/.bad.al): the underlying platform bug (microsoft/
  ALAppExtensions#23935) was closed as completed in Feb 2024; cannot be
  reproduced or bc-version-pinned on any currently supported version.
- table-relation-test-exclude-known-invalid-relations-via-event.md: added
  the [Scope('OnPrem')] boundary verified against BCApps' Table Relation
  Test codeunit.
- use-assert-isfalse-not-asserterror-for-boolean-checks.md: added a Scope
  section resolving the overlap with asserterror-needs-expectederror-and-code.
- al-testing-review.md: fixed the shared-fixture cue to catch the actual
  anti-pattern instead of the compliant shape, added the missing cue for
  use-assert-isfalse-not-asserterror-for-boolean-checks, wired precedence
  between it and the generic asserterror rule, and removed the cue for the
  deleted article.
- Added in-file Source provenance (specific fluxxus.nl post per article,
  with what was independently verified vs. taken from the post) to the
  three surviving externally-inspired articles, per Jesper's request that
  provenance live in the knowledge file itself, not only the PR description.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-09-21 22:49:17 +02:00
..
al-appsource-review.md Add AL-focused AppSource validation guidance (#142) 2026-09-14 12:42:45 +02:00
al-breaking-changes-review.md Add bounded knowledge retrieval (#179) 2026-09-11 12:35:31 +02:00
al-code-review.md Add source-verified Finance knowledge and review domain (#57) 2026-09-21 10:20:41 +02:00
al-data-modeling-review.md Add foundational AL developer knowledge (#195) 2026-09-21 10:15:39 +02:00
al-error-handling-review.md Add bounded knowledge retrieval (#179) 2026-09-11 12:35:31 +02:00
al-events-review.md knowledge(events): ChangeCompany leaves triggers and trigger-event subscribers running in the calling company (#152) 2026-09-15 12:34:28 +02:00
al-finance-review.md Add source-verified Finance knowledge and review domain (#57) 2026-09-21 10:20:41 +02:00
al-interfaces-review.md Add foundational AL developer knowledge (#195) 2026-09-21 10:15:39 +02:00
al-performance-review.md Add Job Queue reliability and scheduling guidance (#148) 2026-09-14 12:44:30 +02:00
al-privacy-review.md Add bounded knowledge retrieval (#179) 2026-09-11 12:35:31 +02:00
al-query-review.md Add query filter semantics guidance (#186) 2026-09-15 12:51:15 +02:00
al-reporting-review.md Add reporting review guidance and evaluation fixtures (#183) 2026-09-15 10:38:32 +02:00
al-scm-review.md Add SCM functional knowledge domain (#192) 2026-09-21 10:16:44 +02:00
al-security-review.md Add bounded knowledge retrieval (#179) 2026-09-11 12:35:31 +02:00
al-style-review.md Clarify locale-safe DateFormula Evaluate inputs (#193) 2026-09-21 10:16:07 +02:00
al-telemetry-review.md Add bounded knowledge retrieval (#179) 2026-09-11 12:35:31 +02:00
al-testing-review.md Address second round of Jesper Schulz-Wedde's review on PR #159 2026-09-21 22:49:17 +02:00
al-ui-review.md Add foundational AL developer knowledge (#195) 2026-09-21 10:15:39 +02:00
al-upgrade-review.md Add foundational AL developer knowledge (#195) 2026-09-21 10:15:39 +02:00
al-web-services-review.md Add bounded knowledge retrieval (#179) 2026-09-11 12:35:31 +02:00