mirror of
https://github.com/microsoft/BCQuality.git
synced 2026-08-06 17:36:53 +01:00
faeacb2484
Add 12 atomic knowledge articles under microsoft/knowledge/events covering general AL event-design best practices: IsHandled initialization and OnAfter preservation, appending new event parameters, position-based event naming, reusing/extending events, avoiding per-iteration publishing, Temp-prefixing temporary record parameters, unabbreviated parameter names, preferring the this keyword over IncludeSender, avoiding loosely typed parameters, not mutating existing event contracts, and not bypassing critical operations with IsHandled. Each article ships a .good.al and .bad.al demonstration sample (object IDs 50240-50296; not compiled by CI). Extend the al-events-review leaf Worklist with one targeted check per new rule. Additive only; no contract or wiring change (events leaf already wired). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
31 lines
1.1 KiB
AL
31 lines
1.1 KiB
AL
// Demonstration-only AL. Not compiled by CI; illustrates the article.
|
|
codeunit 50240 "IsHandled Init Good Sample"
|
|
{
|
|
procedure ApplyDiscounts(var SalesHeader: Record "Sales Header")
|
|
var
|
|
DiscountPct: Decimal;
|
|
IsHandled: Boolean;
|
|
begin
|
|
IsHandled := false;
|
|
OnBeforeApplyHeaderDiscount(SalesHeader, DiscountPct, IsHandled);
|
|
if not IsHandled then
|
|
DiscountPct := 5;
|
|
|
|
// Reset before reusing the same variable for the next event so a
|
|
// subscriber that handled the first raise can't suppress this one.
|
|
IsHandled := false;
|
|
OnBeforeApplyPaymentDiscount(SalesHeader, DiscountPct, IsHandled);
|
|
if not IsHandled then
|
|
DiscountPct += 2;
|
|
end;
|
|
|
|
[IntegrationEvent(false, false)]
|
|
local procedure OnBeforeApplyHeaderDiscount(var SalesHeader: Record "Sales Header"; var DiscountPct: Decimal; var IsHandled: Boolean)
|
|
begin
|
|
end;
|
|
|
|
[IntegrationEvent(false, false)]
|
|
local procedure OnBeforeApplyPaymentDiscount(var SalesHeader: Record "Sales Header"; var DiscountPct: Decimal; var IsHandled: Boolean)
|
|
begin
|
|
end;
|
|
}
|