bcquality/microsoft/skills/review
Michael Dieringer 018e62767d
2 AL/BC patterns: TableRelation field length and RecordRef.Open Temp parameter (#208)
* Add TableRelation field-length and RecordRef.Open Temp knowledge

- data-modeling: tablerelation-field-length-must-match-related-field
  (exact length for unconditional relations, at least the longest target
  when all relations are conditional; no compile-time diagnostic)
- testing: recordref-open-temp-parameter-defeats-real-table-checks
  (a temp-opened RecordRef is empty, so existence/uniqueness checks on it
  never see persisted rows; cross-links use-generateguid article)
- Wire both into the review leaves and register the fixture pairs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Address review: TableRelation validation carve-out, RecordRef nits

- tablerelation: fields with ValidateTableRelation/TestTableRelation = false
  are skipped by codeunit 134926 and may be longer (filter/totaling
  fields); shorter is still a finding. Add Code/Text type rule, BaseApp
  evidence, a ValidateTableRelation = false filter field to the good
  fixture, and the carve-out to the data-modeling cue.
- recordref: add FindLast/Next, relabel SplitLocalTableFilter as filter
  splitting, mark fixtures as test-library-style helpers.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Drop unverified claim about where-filtered relations

The Table Relations Metadata mapping of where(...) filters to
Condition Field No. is not documented and could not be verified; the
rule does not depend on it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Jesper Schulz-Wedde <jesper.schulzwedde@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2026-10-06 13:30:37 +02:00
..
al-appsource-review.md 18 more AL/BC patterns: data-modeling, testing, style, security, error-handling, ui, upgrade, web-services, appsource (#157) 2026-09-29 17:12:51 +02:00
al-breaking-changes-review.md 18 AL/BC patterns: style, data-modeling, web-services, appsource, breaking-changes, performance, testing (#156) 2026-09-29 12:48:17 +02:00
al-code-review.md Validate composed reviews against the expected leaf worklist (#204) 2026-10-02 10:27:27 +02:00
al-data-modeling-review.md 2 AL/BC patterns: TableRelation field length and RecordRef.Open Temp parameter (#208) 2026-10-06 13:30:37 +02:00
al-error-handling-review.md 3 AL/BC patterns: Insert/Delete trigger defaults on master data and declined Confirm in OnValidate (#209) 2026-10-05 14:46:27 +02:00
al-events-review.md knowledge(events): database trigger setup flags may only be set to true (#213) 2026-10-05 14:59:53 +02:00
al-finance-review.md Add source-verified Finance knowledge and review domain (#57) 2026-09-21 10:20:41 +02:00
al-interfaces-review.md Add foundational AL developer knowledge (#195) 2026-09-21 10:15:39 +02:00
al-performance-review.md knowledge(performance): grouped query (Count + ColumnFilter = HAVING) for distinct values and duplicates (#215) 2026-10-05 14:59:15 +02:00
al-privacy-review.md Add retention policy knowledge to the privacy domain (#177) 2026-10-05 15:02:04 +02:00
al-query-review.md Add query filter semantics guidance (#186) 2026-09-15 12:51:15 +02:00
al-reporting-review.md Add reporting review guidance and evaluation fixtures (#183) 2026-09-15 10:38:32 +02:00
al-scm-review.md Strengthen review contracts and add AL reliability guidance (#196) 2026-09-29 13:03:39 +02:00
al-security-review.md 18 more AL/BC patterns: data-modeling, testing, style, security, error-handling, ui, upgrade, web-services, appsource (#157) 2026-09-29 17:12:51 +02:00
al-style-review.md knowledge(style): a new procedure that changes the page's current record should take it as var Record (#216) 2026-10-05 14:42:22 +02:00
al-telemetry-review.md Add bounded knowledge retrieval (#179) 2026-09-11 12:35:31 +02:00
al-testing-review.md 2 AL/BC patterns: TableRelation field length and RecordRef.Open Temp parameter (#208) 2026-10-06 13:30:37 +02:00
al-ui-review.md 2 AL/BC UI patterns: client-expression in-list (AL0573) and Role Center AccessByPermission (#207) 2026-10-02 09:53:14 +02:00
al-upgrade-review.md knowledge(upgrade): upgrade code must not use ChangeCompany (#210) 2026-10-02 11:35:11 +02:00
al-web-services-review.md 18 more AL/BC patterns: data-modeling, testing, style, security, error-handling, ui, upgrade, web-services, appsource (#157) 2026-09-29 17:12:51 +02:00