bcquality/microsoft/knowledge
Michael Dieringer 0120b874b2 Address Jesper Schulz-Wedde's review on PR #157
- release-must-update-app-version.md: reframe around AppSource's actual
  strict full-version-ordering requirement; scope branching-policy
  claims as team convention, not platform rule.
- pictures-must-use-media-not-blob.md: MediaSet is a collection of
  independent media objects, not automatic image variants/thumbnails.
- log-writes-must-survive-rollback.{md,good.al}: StartSession's only
  data channel into the new session is its Record parameter to a
  TableNo-scoped codeunit; a setter called on a local instance before
  starting the session populates nothing in the new session.
- exposed-objects-must-be-in-a-permission-set.md: correct the three
  exposure mechanisms (Web Services config, PageType/QueryType=API,
  ServiceEnabled as a method-only attribute).
- pages-must-not-contain-business-logic.md: scope to persisted
  mutations and cross-entry-point rules; presentation-only
  calculations and table-owned invariants are not violations.
- given-blocks-must-cover-full-precondition-chain.good.al: replace
  invented LibrarySales calls with the real API
  (CreateCustomer/CreateSalesOrderForCustomerNo/PostSalesDocument).
- test-feature-scenario-tags.{md,good.al}: move [SCENARIO] inside the
  test procedure body to match the current BCApps corpus; keep
  [FEATURE] at codeunit level per Microsoft's own documented option.
- ui-test-codeunit-naming.md: scope the _UT suffix and adjacent-ID
  pairing as an explicit team convention, not a BCApps-wide standard.
- page-design-must-match-bc-page-type-conventions.md /
  table-design-must-match-bc-table-type-conventions.md: Card's
  single-key primary-key claim is a contextual heuristic, not a
  mandatory constraint (Ship-to Address, Customer/Vendor Bank Account
  are real composite-key Card pages); a Subsidiary table with its own
  identity commonly gets List+Card, not Worksheet/Tabular.
- api-page-least-privilege-write-access.{md,good.al}: only page-placed
  fields are ever exposed; set InsertAllowed/DeleteAllowed=false in the
  good sample so a narrow field set can't still create/delete records.
- source-organized-by-feature-not-object-type.md,
  test-one-when-per-test.md: scope as team/testing-design conventions,
  not Microsoft platform requirements.
- upgrade-tag-logic-must-not-nest-deeply.md: add the Microsoft Learn
  citation that already backs the two-level nesting limit.
- Wire the new articles into the testing/data-modeling/error-handling/
  security/ui review skills' candidate-selection signals.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-09-21 22:43:16 +02:00
..
appsource Address Jesper Schulz-Wedde's review on PR #157 2026-09-21 22:43:16 +02:00
breaking-changes Separate analyzer rules from BCQuality knowledge (#178) 2026-09-11 09:26:14 +02:00
data-modeling Address Jesper Schulz-Wedde's review on PR #157 2026-09-21 22:43:16 +02:00
error-handling Address Jesper Schulz-Wedde's review on PR #157 2026-09-21 22:43:16 +02:00
events knowledge(events): ChangeCompany leaves triggers and trigger-event subscribers running in the calling company (#152) 2026-09-15 12:34:28 +02:00
finance Add source-verified Finance knowledge and review domain (#57) 2026-09-21 10:20:41 +02:00
interfaces Add foundational AL developer knowledge (#195) 2026-09-21 10:15:39 +02:00
performance Fix Job Queue sample links (#184) 2026-09-15 09:32:40 +02:00
privacy Improve partner onboarding and documentation navigation (#174) 2026-09-09 17:31:03 +02:00
query Add query filter semantics guidance (#186) 2026-09-15 12:51:15 +02:00
reporting Add reporting review guidance and evaluation fixtures (#183) 2026-09-15 10:38:32 +02:00
scm Add SCM functional knowledge domain (#192) 2026-09-21 10:16:44 +02:00
security Address Jesper Schulz-Wedde's review on PR #157 2026-09-21 22:43:16 +02:00
style Address Jesper Schulz-Wedde's review on PR #157 2026-09-21 22:43:16 +02:00
telemetry Improve partner onboarding and documentation navigation (#174) 2026-09-09 17:31:03 +02:00
testing Address Jesper Schulz-Wedde's review on PR #157 2026-09-21 22:43:16 +02:00
ui Address Jesper Schulz-Wedde's review on PR #157 2026-09-21 22:43:16 +02:00
upgrade Address Jesper Schulz-Wedde's review on PR #157 2026-09-21 22:43:16 +02:00
web-services Address Jesper Schulz-Wedde's review on PR #157 2026-09-21 22:43:16 +02:00
.gitkeep Add .gitkeep files to community and microsoft directories; remove .gitkeep from samples 2026-04-17 06:03:14 +02:00