mirror of
https://github.com/microsoft/BCQuality.git
synced 2026-10-05 06:36:55 +01:00
67962727f6
Six carried-over threads: - api-page-least-privilege-write-access fixtures: added the mandatory EntityName/EntitySetName properties (AL0485). - pages-must-not-contain-business-logic fixtures: Sales Line has no "Total Amount" field; replaced with the real "Line Amount" (field 103). - test-feature-scenario-tags.good.al and test-one-when-per-test.good.al: CreatePriceHeader leaves a price list in Draft status, which price calculation ignores. Added Validate(Status, Active) + Modify before the sales line that depends on it. Verified Status field/enum against PriceListHeader.Table.al and PriceStatus.Enum.al in the BCApps clone. - exposed-objects-must-be-in-a-permission-set.md: a published codeunit is a SOAP endpoint (SOAP is deprecated), not OData - Page/Query are the OData object types. Corrected and pointed new integrations at API pages/queries instead. - al-error-handling-review.md: the log-writes-must-survive-rollback cue selected on Session.StartSession, which only appears in the compliant fix, never in the anti-pattern - the bad fixture could never be worklisted. Recued on the actual risk shape (log insert around a failed TryFunction/GetLastError* path, then raise/propagate), with StartSession as an explicit compliant discriminator instead. - page-design-must-match-bc-page-type-conventions.md: the enum value is NavigatePage, not Navigate; noted the type list is a selected subset, not an exhaustive PageType catalogue (PromptDialog, ConfigurationDialog, UserControlHost, XmlPort also exist, out of this article's scope). Four new correctness gaps: - release-must-update-app-version.md: "the version is the only identity" was backwards - id is the app's stable identity, version identifies a release/code-state of it. - defensive-vs-offensive-code-must-match-blast-radius.good.al: the "low blast radius" example had no else branch, so a failed Customer.Get() left the field at its prior/default value instead of the explicit chosen fallback the article claims to demonstrate. Added the else. - bcpt-scenarios-must-be-app-specific.good.al: InitTest and both measured StartScenario/EndScenario sections were empty/comment-only, so the "app-specific" fixture measured no actual work. Filled in a real, self-contained header+line creation path. - upgrade-tag-logic-must-not-nest-deeply.good.al: the flattened version dropped both safety conditions the bad fixture had (Discount % = 0, nonblank posting group), silently changing behavior instead of just removing nesting. Extracted the guarded update into a helper with both conditions preserved as early exits. Also converted this PR's remaining plain-backtick "See sample:" sample references (16 articles) to the READ-convention markdown-link form, matching the fix already made on #156/#158. Rebased onto upstream/main (conflicts in al-ui-review.md, al-style-review.md, al-upgrade-review.md against merged upstream PRs - all additive, both sides' worklist cues retained).
56 lines
2.5 KiB
Perl
56 lines
2.5 KiB
Perl
[Test]
|
|
procedure GetPrice_CustomerPrice_ReturnsCorrectUnitPrice()
|
|
var
|
|
Customer: Record Customer;
|
|
Item: Record Item;
|
|
PriceListHeader: Record "Price List Header";
|
|
PriceListLine: Record "Price List Line";
|
|
SalesHeader: Record "Sales Header";
|
|
SalesLine: Record "Sales Line";
|
|
begin
|
|
// [GIVEN] a customer with a price list line for the item
|
|
LibrarySales.CreateCustomer(Customer);
|
|
LibraryInventory.CreateItem(Item);
|
|
LibraryPriceCalculation.CreatePriceHeader(
|
|
PriceListHeader, PriceListHeader."Price Type"::Sale, "Price Source Type"::Customer, Customer."No.");
|
|
LibraryPriceCalculation.CreateSalesPriceLine(
|
|
PriceListLine, PriceListHeader.Code, "Price Source Type"::Customer, Customer."No.",
|
|
"Price Asset Type"::Item, Item."No.");
|
|
// CreatePriceHeader leaves the list in Draft status, which price calculation ignores.
|
|
PriceListHeader.Validate(Status, PriceListHeader.Status::Active);
|
|
PriceListHeader.Modify(true);
|
|
// [WHEN]
|
|
LibrarySales.CreateSalesDocumentWithItem(
|
|
SalesHeader, SalesLine, SalesHeader."Document Type"::Order, Customer."No.", Item."No.", 1, '', 0D);
|
|
// [THEN]
|
|
Assert.AreEqual(PriceListLine."Unit Price", SalesLine."Unit Price", 'Unit price must match price list');
|
|
end;
|
|
|
|
[Test]
|
|
procedure GetPriceLines_TwoMinimumQuantityLines_ReturnsBoth()
|
|
var
|
|
Customer: Record Customer;
|
|
Item: Record Item;
|
|
PriceListHeader: Record "Price List Header";
|
|
PriceListLine: Record "Price List Line";
|
|
begin
|
|
// [GIVEN] a customer price list with two minimum-quantity price lines for the same item
|
|
LibrarySales.CreateCustomer(Customer);
|
|
LibraryInventory.CreateItem(Item);
|
|
LibraryPriceCalculation.CreatePriceHeader(
|
|
PriceListHeader, PriceListHeader."Price Type"::Sale, "Price Source Type"::Customer, Customer."No.");
|
|
LibraryPriceCalculation.CreateSalesPriceLine(
|
|
PriceListLine, PriceListHeader.Code, "Price Source Type"::Customer, Customer."No.",
|
|
"Price Asset Type"::Item, Item."No.");
|
|
PriceListLine.Validate("Minimum Quantity", 10);
|
|
PriceListLine.Modify(true);
|
|
LibraryPriceCalculation.CreateSalesPriceLine(
|
|
PriceListLine, PriceListHeader.Code, "Price Source Type"::Customer, Customer."No.",
|
|
"Price Asset Type"::Item, Item."No.");
|
|
PriceListLine.Validate("Minimum Quantity", 50);
|
|
PriceListLine.Modify(true);
|
|
// [WHEN]
|
|
PriceListLine.SetRange("Price List Code", PriceListHeader.Code);
|
|
// [THEN]
|
|
Assert.AreEqual(2, PriceListLine.Count(), 'Exactly two price lines expected');
|
|
end;
|