mirror of
https://github.com/microsoft/BCQuality.git
synced 2026-10-05 06:36:55 +01:00
a2685b9c86
* Frist draft for Prices Incl. VAT Data Modelling * knowledge(data-modeling): cover prepayment, service line and ExclTax helper in Prices Including VAT article Extend the community article on sales/purchase line prices following the header's Prices Including VAT: - Group the line fields: fields that follow the header flag (Unit Price, Direct Unit Cost, Line Amount, discounts, Prepmt. Line Amount, Prepmt. Amt. Inv., Prepmt Amt to Deduct, Prepmt Amt Deducted) versus fields with a fixed basis (Amount, VAT Base Amount, Prepayment Amount are net; Amount Including VAT, Prepmt. Amt. Incl. VAT, Prepmt. Amount Inv. Incl. VAT are gross). - Add the rule to combine only fields of the same group, with BaseApp's UpdatePrepmtAmounts as the correct example. - Add the misleading-name case: CalculateOutstandingAmountExclTax on Sales Line and Purchase Line is based on Line Amount and includes VAT on a Prices Including VAT document. BaseApp pairs it only with Prepmt. Line Amount (same basis); extension code that treats it as net is wrong. - Mention that Service Line uses the same caption switch and UpdateVATAmounts split for Unit Price and Line Amount. - Samples: add GetOutstandingNetAmount (bad: trusts the helper's name; good: takes the uninvoiced share of Amount). - al-data-modeling-review: widen the scope and the worklist rule to service lines, the extra prepayment fields and CalculateOutstandingAmountExclTax, and exclude code that only combines fields of the same group. Verified against BCApps W1 BaseApp (SalesLine, PurchaseLine, ServiceLine, SalesHeader, Sales Line CaptionClass Mgmt). Refs #151 * knowledge(data-modeling): move Prices Including VAT article to Microsoft layer data-modeling is a Microsoft-owned review domain consumed by microsoft/skills/review/al-data-modeling-review.md, and docs/contributing.md does not allow Community as a staging layer for such domains. Move the article and its .good.al/.bad.al samples to microsoft/knowledge/data-modeling/. Content is unchanged; the slug-based evaluation entry stays as is.
33 lines
1.6 KiB
AL
33 lines
1.6 KiB
AL
// Demonstration only; independently authored, not copied from BaseApp.
|
|
codeunit 50641 "Sales Doc. VAT Basis Bad"
|
|
{
|
|
procedure GetNetAndGrossTotals(SalesHeader: Record "Sales Header"; var NetTotal: Decimal; var GrossTotal: Decimal)
|
|
var
|
|
SalesLine: Record "Sales Line";
|
|
begin
|
|
SalesLine.SetRange("Document Type", SalesHeader."Document Type");
|
|
SalesLine.SetRange("Document No.", SalesHeader."No.");
|
|
if SalesLine.FindSet() then
|
|
repeat
|
|
// Wrong: "Line Amount" already includes VAT when the header has Prices Including VAT,
|
|
// so NetTotal is gross and VAT is added a second time. Invoice discount is also ignored.
|
|
NetTotal += SalesLine."Line Amount";
|
|
GrossTotal += SalesLine."Line Amount" * (1 + SalesLine."VAT %" / 100);
|
|
until SalesLine.Next() = 0;
|
|
end;
|
|
|
|
procedure GetOutstandingNetAmount(SalesLine: Record "Sales Line"): Decimal
|
|
begin
|
|
// Wrong: despite its name, CalculateOutstandingAmountExclTax is based on "Line Amount"
|
|
// and therefore includes VAT on a Prices Including VAT document.
|
|
exit(SalesLine.CalculateOutstandingAmountExclTax());
|
|
end;
|
|
|
|
procedure SetUnitPriceFromNetSourcePrice(var SalesLine: Record "Sales Line"; NetSourcePrice: Decimal)
|
|
begin
|
|
// Wrong: on a Prices Including VAT document this net price is read as a gross price,
|
|
// so the net line amount drops to NetSourcePrice / (1 + "VAT %" / 100).
|
|
SalesLine.Validate("Unit Price", NetSourcePrice);
|
|
SalesLine.Modify(true);
|
|
end;
|
|
}
|