mirror of
https://github.com/microsoft/BCQuality.git
synced 2026-10-05 22:56:55 +01:00
82422f94c9
* Avoid Public Event publisher * knowledge(events): scope public-publisher detection to same-app raisers The detection rule flagged every public event publisher, including ones deliberately public so a sibling app can raise them - a contract `internal` cannot express across app boundaries. Scope the finding to publishers that are public although only their own app raises them, and record the cross-app case as a valid Best Practice option. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0b67b90d-e4b4-4b92-9684-726c72c43b3f --------- Co-authored-by: Jesper Schulz-Wedde <jesper.schulzwedde@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0b67b90d-e4b4-4b92-9684-726c72c43b3f
27 lines
838 B
AL
27 lines
838 B
AL
codeunit 50149 "Sec Sample CommitBeh Good"
|
|
{
|
|
[CommitBehavior(CommitBehavior::Ignore)]
|
|
[IntegrationEvent(true, false)]
|
|
local procedure OnBeforeApplyingDiscount(var Customer: Record Customer)
|
|
begin
|
|
end;
|
|
|
|
procedure ApplyDiscount(var Customer: Record Customer)
|
|
begin
|
|
Customer."Customer Price Group" := 'VIP';
|
|
Customer.Modify(true);
|
|
OnBeforeApplyingDiscount(Customer);
|
|
if Customer."Credit Limit (LCY)" <= 0 then
|
|
Error('Customer %1 not eligible', Customer."No.");
|
|
Commit();
|
|
end;
|
|
}
|
|
|
|
codeunit 50150 "Sec Sample CommitBeh Good Sub"
|
|
{
|
|
[EventSubscriber(ObjectType::Codeunit, Codeunit::"Sec Sample CommitBeh Good", 'OnBeforeApplyingDiscount', '', true, true)]
|
|
local procedure NotifyOther(var Customer: Record Customer)
|
|
begin
|
|
Commit();
|
|
end;
|
|
}
|