Microsoft/bcquality
1
0
Fork 0
mirror of https://github.com/microsoft/BCQuality.git synced 2026-10-05 14:46:55 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Address agent review feedback

Browse source
This commit is contained in:
Stefano Demiliani 2026-08-27 16:33:40 +02:00
parent 38d341eabb
commit e98fb8ec38
11 changed files with 63 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

17
tools/Test-ReviewFixtures.ps1
View file

@ -203,7 +203,20 @@ foreach ($domain in $leafDomains) {
}
$selectedArticle = $articles | Where-Object BaseName -eq $articleName | Select-Object -First 1
if (-not $selectedArticle) {
$problems.Add("${domain}: override article does not exist: $articleName.md") | Out-Null
$articleExists = @(
foreach ($layer in $layers) {
$articleFile = Join-Path $Root "$($layer.Name)/knowledge/$domain/$articleName.md"
if (Test-Path -LiteralPath $articleFile -PathType Leaf) {
$articleFile
}
}
).Count -gt 0
if ($articleExists) {
$problems.Add("${domain}: override article does not have both .good.al and .bad.al companion samples: $articleName.md") | Out-Null
} else {
$problems.Add("${domain}: override article does not exist: $articleName.md") | Out-Null
}
continue
}
} else {
$selectedArticle = $articles | Select-Object -First 1
@ -214,7 +227,7 @@ foreach ($domain in $leafDomains) {
}
$articlePath = [string]$selectedArticle.ArticlePath
$sampleDirectory = Split-Path -Parent $articlePath
$sampleDirectory = (Split-Path -Parent $articlePath).Replace('\', '/')
$context = if ($override -and ($override.PSObject.Properties.Name -contains 'context')) {
[string]$override.context
} else {