mirror of
https://github.com/microsoft/BCQuality.git
synced 2026-10-05 14:46:55 +01:00
Fix four merge-critical issues from Jesper's 2026-09-22 review
- al-testing-review.md: the generic ExpectedError cue's asserterror Assert.IsTrue/IsFalse exclusion was unconditional, but the specialized rule it deferred to only claims the pure-inversion shape. A test expecting the guarded Boolean-returning call itself to raise fell through both routes. Narrowed the exclusion to the same inversion-only condition the specialized cue already uses. - asserterror-needs-expectederror-and-code.md: the rollback-sentinel exception (a trailing asserterror Error(...) used purely to force a fixture rollback, not to verify a specific failure) previously lived only in skill routing prose. Encoded it directly in the article's Anti Pattern section so every consumer of the knowledge base sees it, not just this one skill. - commit-shared-test-fixture-inside-lazy-initialize.good.al/.bad.al: replaced hand-rolled Item.Init()/Insert(true) with LibraryInventory.CreateItem, so the canonical fixture doesn't itself trigger use-library-codeunits-for-test-fixtures. - table-relation-test-exclude-known-invalid-relations-via-event.good.al/ .bad.al: declared minimal "Sample Setup"/"Sample Header" tables inline instead of referencing undefined symbols, matching this repo's own convention that every fixture is self-contained.
This commit is contained in:
parent
69b09db3a6
commit
e3d9b8eb25
6 changed files with 62 additions and 7 deletions
|
|
@ -3,6 +3,7 @@ codeunit 50142 "Sample Test Library"
|
|||
Subtype = Test;
|
||||
|
||||
var
|
||||
LibraryInventory: Codeunit "Library - Inventory";
|
||||
Initialized: Boolean;
|
||||
SharedItemNo: Code[20];
|
||||
RollBackMsg: Label 'Revert back the tables to their original state.';
|
||||
|
|
@ -21,9 +22,7 @@ codeunit 50142 "Sample Test Library"
|
|||
var
|
||||
Item: Record Item;
|
||||
begin
|
||||
Item.Init();
|
||||
Item."No." := 'SAMPLE-SHARED';
|
||||
Item.Insert(true);
|
||||
LibraryInventory.CreateItem(Item);
|
||||
SharedItemNo := Item."No.";
|
||||
end;
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue