mirror of
https://github.com/microsoft/BCQuality.git
synced 2026-08-08 18:31:36 +01:00
Add CMFRT coding standards documentation and examples
- Introduced guidelines for "one codeunit one global function" architecture to enforce single responsibility in AL code. - Added best practices and anti-patterns for adding parameters via overloads to maintain backward compatibility. - Documented the importance of never deleting members in AL and always marking them as obsolete. - Established the requirement for OnBefore and OnAfter integration events for global procedures to enhance extensibility. - Defined naming conventions for CMFRT objects, including prefixes and object ID ranges to avoid conflicts. - Implemented patterns for case statements to ensure all cases are handled, including the necessity of an else clause. - Introduced the interface injection pattern to allow pluggable operations in table-level code. - Recommended using Confirm Management for user confirmations to improve testability. - Established a three-permission set pattern for security to ensure proper access control. - Created a review skill for CMFRT AL standards to automate compliance checks against established guidelines.
This commit is contained in:
parent
4119417ce4
commit
c72c0ad685
35 changed files with 866 additions and 0 deletions
|
|
@ -0,0 +1,37 @@
|
|||
// Subscriber codeunit calls the BASE TABLE procedure — not the implementation codeunit.
|
||||
codeunit 2045720 "CMFRT BA Sales Subscribers"
|
||||
{
|
||||
[EventSubscriber(ObjectType::Codeunit, Codeunit::"Sales-Post", 'OnAfterPostSalesDoc', '', false, false)]
|
||||
local procedure CMFRTBAOnAfterPostSalesDoc(var SalesHeader: Record "Sales Header")
|
||||
var
|
||||
CMFRTBAItem: Record "CMFRT BA Item";
|
||||
begin
|
||||
// Route through the base table — integration events fire normally.
|
||||
CMFRTBAItem.CMFRTBASyncPostedSalesDoc(SalesHeader."No.");
|
||||
end;
|
||||
}
|
||||
|
||||
// Base table owns all entry points to implementation codeunits.
|
||||
table 2045095 "CMFRT BA Item"
|
||||
{
|
||||
procedure CMFRTBASyncPostedSalesDoc(SalesDocNo: Code[20])
|
||||
var
|
||||
SyncImpl: Codeunit "CMFRT BA SyncPostedDoc Impl";
|
||||
Handled: Boolean;
|
||||
begin
|
||||
OnBeforeCMFRTBASyncPostedSalesDoc(SalesDocNo, Handled);
|
||||
if Handled then
|
||||
exit;
|
||||
CMFRTBASyncPostedSalesDoc(SyncImpl);
|
||||
end;
|
||||
|
||||
procedure CMFRTBASyncPostedSalesDoc(SyncImpl: Interface "CMFRT BA ISyncPostedDoc")
|
||||
begin
|
||||
SyncImpl.CMFRTBASyncPostedSalesDoc(Rec);
|
||||
end;
|
||||
|
||||
[IntegrationEvent(false, false)]
|
||||
local procedure OnBeforeCMFRTBASyncPostedSalesDoc(SalesDocNo: Code[20]; var Handled: Boolean)
|
||||
begin
|
||||
end;
|
||||
}
|
||||
Loading…
Add table
Add a link
Reference in a new issue