mirror of
https://github.com/microsoft/BCQuality.git
synced 2026-10-05 22:56:55 +01:00
Fire haandhaevelseslag for [CURABIS-STATE]-tilstandssporet
Michael: "lad os bygge alle 4" - rangeret efter styrke fra sidste samtale. 1. Smiley v6: close-gaten laeser nu det faktiske [CURABIS-STATE]-spor tilbage FOER merge, i stedet for at stole paa sessionens egen hukommelse. Mangler et tidligere checkpoint, blokerer merge - selv hvis testen er groen og reviewet lige sagde APPROVE nu. 2. al-review v3: "state trail complete?" er nu et Titus-tjekpunkt der giver BLOCK, ikke bare en note - et ufuldstaendigt spor er i sig selv et vedligeholdelsesfund. 3. Ny .github/workflows/curabis-task-state-check.yml: reelt deterministisk haandhaevelse for AppSource (parser PR-body'ens tjekliste, fejler hvis en senere fase er tjekket mens en tidligere ikke er). Testet mod fire cases (gyldig raekkefolge, ugyldig, ingen sektion, tom sektion) - alle korrekte. Kraever et manuelt engangs-trin (branch protection required check) som filudrulningen ikke selv kan saette. 4. Roemer v6: ny station 13, retrospektiv - stikprover de sidste ~10 afsluttede BC-opgaver/mergede PR'er for spor-fuldstaendighed, fanger drift ingen enkelt opgaves egen gate fangede. Kun opgaver lukket efter 2026-08-03 flages - reglen fandtes ikke foer. curabis-standard.agent.md: ny artefakt-raekke + Mode A step 4h (deploy workflow-filen, mind om branch protection-trinet) + Mode B repo-tabel-raekke. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
parent
bfc2c59cc9
commit
bcbc4acced
5 changed files with 137 additions and 3 deletions
|
|
@ -1,7 +1,7 @@
|
|||
---
|
||||
kind: action-skill
|
||||
id: curabis-al-review
|
||||
version: 2
|
||||
version: 3
|
||||
title: CURABIS AL independent review (Torvalds & Winters)
|
||||
description: Independent per-change code reviewer. Runs after the TDD green gate and before merge — the fourth checkpoint, separate from the implementer and from portfolio-level rule governance (Rømer/Immanuel/Court, who ask "is the ruleset healthy", not "is THIS change good"). Two lenses - Linus Torvalds (BC/AL domain-technical correctness, backward compatibility, performance, security) and Titus Winters (general software-engineering maintainability, architecture, complexity over time).
|
||||
inputs: [diff, task-description]
|
||||
|
|
@ -102,6 +102,15 @@ remember to request. See `smiley.agent.md`.
|
|||
- Consistency with the rest of the codebase
|
||||
- Should this even be implemented this way at all — not "does it work" but
|
||||
"is this the right way to have solved it"?
|
||||
- **State trail complete?** (2026-08-03) Read back the `[CURABIS-STATE]`
|
||||
comments (PTE) or PR checklist (AppSource) — `TASK_STARTED`,
|
||||
`RED_CONFIRMED`, `GREEN_CONFIRMED` must all be present before this review
|
||||
even runs. A missing earlier checkpoint is a maintainability finding in
|
||||
its own right: the record this task claims to have followed the lifecycle
|
||||
gates can't be trusted after the fact, which defeats the entire point of
|
||||
`[[task-state-lives-in-the-mandatory-artifact]]`. This is a BLOCKing
|
||||
finding, not a note — the fix is trivial (go check what actually happened
|
||||
and record it truthfully), so there's no reason to let it slide.
|
||||
|
||||
## Protocol
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue